Skip to content

Added comments to middleware-matcher example#40273

Merged
kodiakhq[bot] merged 6 commits intocanaryfrom
steven-tey-patch-1
Sep 13, 2022
Merged

Added comments to middleware-matcher example#40273
kodiakhq[bot] merged 6 commits intocanaryfrom
steven-tey-patch-1

Conversation

@steven-tey
Copy link
Copy Markdown
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue was opened via the examples template. label Sep 6, 2022
Comment thread examples/middleware-matcher/middleware.js Outdated
Comment thread examples/middleware-matcher/middleware.js Outdated
@steven-tey steven-tey requested a review from ijjk September 13, 2022 06:53
ijjk
ijjk previously approved these changes Sep 13, 2022
Comment thread examples/middleware-matcher/middleware.js
@kodiakhq kodiakhq Bot merged commit 260ea55 into canary Sep 13, 2022
@kodiakhq kodiakhq Bot deleted the steven-tey-patch-1 branch September 13, 2022 12:21
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

examples Issue was opened via the examples template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants