Skip to content

[docs] Migrate dynamic routing example to typescript#39806

Merged
ijjk merged 3 commits intovercel:canaryfrom
HaNdTriX:examples/dynamic-routing
Aug 22, 2022
Merged

[docs] Migrate dynamic routing example to typescript#39806
ijjk merged 3 commits intovercel:canaryfrom
HaNdTriX:examples/dynamic-routing

Conversation

@HaNdTriX
Copy link
Copy Markdown
Contributor

@HaNdTriX HaNdTriX commented Aug 22, 2022

Changelog

  • Migrated example to typescript
  • Remove obsolete Link->as prop
  • Normalize Module exports

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue was opened via the examples template. label Aug 22, 2022
ijjk
ijjk approved these changes Aug 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk merged commit 827e120 into vercel:canary Aug 22, 2022
@HaNdTriX HaNdTriX deleted the examples/dynamic-routing branch August 22, 2022 13:38
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees

No one assigned

Labels

examples Issue was opened via the examples template.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HaNdTriX @ijjk