Skip to content

[docs] Avoid next config validation warning#39554

Merged
ijjk merged 1 commit intovercel:canaryfrom
cherniavskii:patch-1
Aug 12, 2022
Merged

[docs] Avoid next config validation warning#39554
ijjk merged 1 commit intovercel:canaryfrom
cherniavskii:patch-1

Conversation

@cherniavskii
Copy link
Copy Markdown
Contributor

@cherniavskii cherniavskii commented Aug 12, 2022

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

Next.js now validates next.config.js and setting assetPath to an empty string results in the following warning:

  {
    "instancePath": "/assetPrefix",
    "schemaPath": "#/properties/assetPrefix/minLength",
    "keyword": "minLength",
    "params": {
      "limit": 1
    },
    "message": "must NOT have fewer than 1 characters"
  }

This was raised in #39161 (comment)

@ijjk ijjk merged commit d9a1c43 into vercel:canary Aug 12, 2022
@cherniavskii cherniavskii deleted the patch-1 branch August 12, 2022 16:02
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cherniavskii @ijjk