Skip to content

docs: update When section of getStaticProps page#39393

Merged
ijjk merged 2 commits intovercel:canaryfrom
sumiren:patch-1
Aug 8, 2022
Merged

docs: update When section of getStaticProps page#39393
ijjk merged 2 commits intovercel:canaryfrom
sumiren:patch-1

Conversation

@sumiren
Copy link
Copy Markdown
Contributor

@sumiren sumiren commented Aug 8, 2022

getStaticProps will be called in conjection with fallback.

It's written in following page, but not in concerned page.
https://nextjs.org/docs/basic-features/data-fetching/get-static-paths

On my environment, pnpm lint detect some errors in files in pacakges and test.
I'm not sure whether CI ignores these errors, but at least it seems my change contains no error, so I checked checklist.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

getStaticProps will be called in conjection with fallback.

it's written in following page, but not in concerned page.
https://nextjs.org/docs/basic-features/data-fetching/get-static-paths
@sumiren sumiren marked this pull request as ready for review August 8, 2022 07:12
Copy link
Copy Markdown
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk merged commit 9f8713f into vercel:canary Aug 8, 2022
@sumiren sumiren deleted the patch-1 branch August 8, 2022 15:38
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants