Merged
Conversation
balazsorban44
suggested changes
Jul 6, 2022
Contributor
balazsorban44
left a comment
There was a problem hiding this comment.
Let's convert to TypeScript. See: https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples
Author
I have updated the PR now to be in TS, but pnpm is not working for me, it fails with GYP error. can we let it run through the CI? |
balazsorban44
suggested changes
Jul 8, 2022
Contributor
balazsorban44
left a comment
There was a problem hiding this comment.
Let's also add a tsconfig.json (running next dev will generate one)
Co-authored-by: Balázs Orbán <info@balazsorban.com>
Author
added. (thanks for the tip, saved my time :D) |
Author
|
@balazsorban44 is there something that needs to be updated? |
steven-tey
previously approved these changes
Aug 30, 2022
Contributor
steven-tey
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the PR! :)
balazsorban44
previously approved these changes
Sep 1, 2022
37b51f1
balazsorban44
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation / Examples
pnpm lintThis PR adds an example for using next.js with axiom.