Skip to content

Fix next info accidentally printing stderr#35556

Merged
kodiakhq[bot] merged 1 commit intocanaryfrom
fix-next-info-stderr
Mar 23, 2022
Merged

Fix next info accidentally printing stderr#35556
kodiakhq[bot] merged 1 commit intocanaryfrom
fix-next-info-stderr

Conversation

@styfle
Copy link
Copy Markdown
Contributor

@styfle styfle commented Mar 23, 2022

I noticed a few issues that had "Output from next info" with the first line as

/bin/sh: pnpm: command not found

This was because execSync() was still printing to stderr when a command was not found.

Changing to execFileSync() fixed it so we no longer print to stderr when a command is not found.

@styfle styfle requested a review from balazsorban44 March 23, 2022 21:40
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Mar 23, 2022
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Mar 23, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-next-info-stderr Change
buildDuration 20.3s 19.6s -620ms
buildDurationCached 7.8s 7.5s -298ms
nodeModulesSize 467 MB 467 MB ⚠️ +51 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-next-info-stderr Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.319 4.238 -0.08
/ avg req/sec 578.89 589.93 +11.04
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.174 2.077 -0.1
/error-in-render avg req/sec 1149.9 1203.91 +54.01
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-next-info-stderr Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28 kB 28 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.6 kB 71.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-next-info-stderr Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix-next-info-stderr Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 192 B 192 B ✓
amp-HASH.js gzip 309 B 309 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.57 kB 2.57 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.48 kB 5.48 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.2 kB 15.2 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix-next-info-stderr Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-next-info-stderr Change
index.html gzip 531 B 531 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 524 B 524 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-next-info-stderr Change
buildDuration 23.8s 23.5s -241ms
buildDurationCached 7.9s 7.5s -357ms
nodeModulesSize 467 MB 467 MB ⚠️ +51 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-next-info-stderr Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.322 4.219 -0.1
/ avg req/sec 578.42 592.6 +14.18
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.164 2.01 -0.15
/error-in-render avg req/sec 1155.46 1243.96 +88.5
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-next-info-stderr Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.2 kB 28.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.1 kB 72.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-next-info-stderr Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix-next-info-stderr Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 313 B 313 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.56 kB 2.56 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.59 kB 5.59 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.33 kB 2.33 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 388 B 388 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.3 kB 15.3 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix-next-info-stderr Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-next-info-stderr Change
index.html gzip 531 B 531 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: e622bc6

@kodiakhq kodiakhq Bot merged commit ef7b535 into canary Mar 23, 2022
@kodiakhq kodiakhq Bot deleted the fix-next-info-stderr branch March 23, 2022 22:33
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk approved these changes

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@styfle @ijjk