Skip to content

Update trace ignore check to check reasons correctly#35511

Merged
ijjk merged 1 commit intovercel:canaryfrom
ijjk:fix/ignore-check
Mar 22, 2022
Merged

Update trace ignore check to check reasons correctly#35511
ijjk merged 1 commit intovercel:canaryfrom
ijjk:fix/ignore-check

Conversation

@ijjk
Copy link
Copy Markdown
Member

@ijjk ijjk commented Mar 22, 2022

This is a follow-up to #35446 and fixes our reasons.get() path as the reasons stores the file relative to base path provided which is the tracingRoot. This also updates our test case to ensure it's using a file handled by a loader instead of a JSON file which doesn't require a loader.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

x-ref: #35446

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Mar 22, 2022
@ijjk ijjk marked this pull request as ready for review March 22, 2022 01:42
@ijjk ijjk requested a review from styfle March 22, 2022 01:42
@ijjk
Copy link
Copy Markdown
Member Author

ijjk commented Mar 22, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/ignore-check Change
buildDuration 22s 21.9s -96ms
buildDurationCached 8.4s 8.3s -106ms
nodeModulesSize 456 MB 456 MB ⚠️ +89 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/ignore-check Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.709 4.669 -0.04
/ avg req/sec 530.86 535.46 +4.6
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.229 2.3 ⚠️ +0.07
/error-in-render avg req/sec 1121.7 1086.94 ⚠️ -34.76
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/ignore-check Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28 kB 28 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.6 kB 71.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/ignore-check Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/ignore-check Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 192 B 192 B ✓
amp-HASH.js gzip 309 B 309 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.57 kB 2.57 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.48 kB 5.48 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.2 kB 15.2 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/ignore-check Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/ignore-check Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/ignore-check Change
buildDuration 27.1s 27.1s ⚠️ +44ms
buildDurationCached 8.4s 8.6s ⚠️ +165ms
nodeModulesSize 456 MB 456 MB ⚠️ +89 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/ignore-check Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.582 4.642 ⚠️ +0.06
/ avg req/sec 545.59 538.54 ⚠️ -7.05
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.205 2.241 ⚠️ +0.04
/error-in-render avg req/sec 1133.84 1115.73 ⚠️ -18.11
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/ignore-check Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.2 kB 28.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.1 kB 72.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/ignore-check Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/ignore-check Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 313 B 313 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.56 kB 2.56 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.59 kB 5.59 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.33 kB 2.33 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 388 B 388 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.3 kB 15.3 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/ignore-check Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/ignore-check Change
index.html gzip 531 B 531 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: fa8c774

styfle
styfle approved these changes Mar 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk merged commit a2accb2 into vercel:canary Mar 22, 2022
@ijjk ijjk deleted the fix/ignore-check branch March 22, 2022 05:03
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@padmaia padmaia Awaiting requested review from padmaia

@huozhi huozhi Awaiting requested review from huozhi

1 more reviewer

@styfle styfle styfle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ijjk @styfle