Skip to content

[examples] Add Tina CMS blog starter#35045

Merged
kodiakhq[bot] merged 11 commits intovercel:canaryfrom
perkinsjr:tina-cms-add
Mar 5, 2022
Merged

[examples] Add Tina CMS blog starter#35045
kodiakhq[bot] merged 11 commits intovercel:canaryfrom
perkinsjr:tina-cms-add

Conversation

@perkinsjr
Copy link
Copy Markdown
Contributor

@perkinsjr perkinsjr commented Mar 4, 2022

Documentation / Examples

  • Adding TInaCMS example using the traditional CMS example

@ijjk ijjk added the examples Issue was opened via the examples template. label Mar 4, 2022
leerob
leerob reviewed Mar 4, 2022
View reviewed changes
Comment thread examples/cms-tina/.tina/schema.ts Outdated
Comment thread examples/cms-tina/components/avatar.js Outdated
Comment thread examples/cms-tina/components/cover-image.js Outdated
Comment thread examples/cms-tina/components/hero-post.js Outdated
Comment thread examples/cms-tina/content/posts/HelloWorld.md Outdated
Comment thread examples/cms-tina/package.json Outdated
@perkinsjr
Copy link
Copy Markdown
Contributor Author

perkinsjr commented Mar 4, 2022

Added the changes requested, and fix the Next starter

@perkinsjr perkinsjr requested a review from leerob March 4, 2022 17:40
leerob
leerob reviewed Mar 4, 2022
View reviewed changes
Comment thread examples/blog-starter/components/avatar.js Outdated
Comment thread examples/cms-tina/components/avatar.js Outdated
leerob
leerob previously approved these changes Mar 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've deployed this, we could add it to the README as a demo URL 😄

@leerob leerob changed the title adding Tina CMS [examples] Add Tina CMS blog starter Mar 4, 2022
@perkinsjr
Copy link
Copy Markdown
Contributor Author

perkinsjr commented Mar 4, 2022

If you've deployed this, we could add it to the README as a demo URL 😄

I actually don't have it deployed. I can come back around once we figure out where it should live (tinacms, my repo etc) and I will add an update to the README.md

@leerob
Copy link
Copy Markdown
Contributor

leerob commented Mar 5, 2022

Looks like two small issues in CI:

/home/runner/work/next.js/next.js/examples/blog-starter/components/avatar.js
[412](https://github.com/vercel/next.js/runs/5428495504?check_suite_focus=true#step:5:412)
  7:17  error  Parsing error: Unexpected token, expected "}" (7:17)
[413](https://github.com/vercel/next.js/runs/5428495504?check_suite_focus=true#step:5:413)

[414](https://github.com/vercel/next.js/runs/5428495504?check_suite_focus=true#step:5:414)
/home/runner/work/next.js/next.js/examples/cms-tina/components/avatar.js
[415](https://github.com/vercel/next.js/runs/5428495504?check_suite_focus=true#step:5:415)
  8:17  error  Parsing error: Unexpected token, expected "}" (8:17)
[416](https://github.com/vercel/next.js/runs/5428495504?check_suite_focus=true#step:5:416)

[417](https://github.com/vercel/next.js/runs/5428495504?check_suite_focus=true#step:5:417)
✖ 2 problems (2 errors, 0 warnings)

@perkinsjr
Copy link
Copy Markdown
Contributor Author

perkinsjr commented Mar 5, 2022

Yup @leerob looks like those were the changes you made to the Avatar. I’ll take a look tomorrow, see why it’s not building.

@perkinsjr
Copy link
Copy Markdown
Contributor Author

perkinsjr commented Mar 5, 2022

Oh I see the problem the end should be a } but we have a ) on the image width and heights

@perkinsjr
Update the width height
c3a8ab4 
Change from ) to }
@perkinsjr
Fix to height width
6919d6a 
Fixing height and width props
@perkinsjr
Copy link
Copy Markdown
Contributor Author

perkinsjr commented Mar 5, 2022

Should be all set now👍

leerob
leerob previously approved these changes Mar 5, 2022
View reviewed changes
@balazsorban44
Copy link
Copy Markdown
Contributor

balazsorban44 commented Mar 5, 2022

@perkinsjr Could you address the linting issues, otherwise, this would be ok to merge.

See: https://github.com/vercel/next.js/runs/5430503399?check_suite_focus=true

@perkinsjr perkinsjr requested a review from huozhi as a code owner March 5, 2022 15:57
@perkinsjr
Copy link
Copy Markdown
Contributor Author

perkinsjr commented Mar 5, 2022

This should be good to go now.

@kodiakhq kodiakhq Bot merged commit b5cc91e into vercel:canary Mar 5, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@steven-tey steven-tey Awaiting requested review from steven-tey

@huozhi huozhi Awaiting requested review from huozhi

1 more reviewer

@leerob leerob leerob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

examples Issue was opened via the examples template.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@perkinsjr @leerob @balazsorban44 @ijjk