Skip to content

fix(examples/with-docker): add npm comment for yarn build#35040

Merged
kodiakhq[bot] merged 1 commit intovercel:canaryfrom
midgleyc:with-docker-npm-comment
Mar 4, 2022
Merged

fix(examples/with-docker): add npm comment for yarn build#35040
kodiakhq[bot] merged 1 commit intovercel:canaryfrom
midgleyc:with-docker-npm-comment

Conversation

@midgleyc
Copy link
Copy Markdown
Contributor

@midgleyc midgleyc commented Mar 4, 2022

There was an npm equivalent for yarn install (npm ci) but not one for yarn build. I've added npm run build as a commented out option.

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue was opened via the examples template. label Mar 4, 2022
@kodiakhq kodiakhq Bot merged commit 946f465 into vercel:canary Mar 4, 2022
@midgleyc midgleyc deleted the with-docker-npm-comment branch March 4, 2022 18:30
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@steven-tey steven-tey Awaiting requested review from steven-tey

+1 more reviewer

@leerob leerob leerob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

examples Issue was opened via the examples template.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@midgleyc @leerob @ijjk