Skip to content

Optimize component type filters#34941

Merged
kodiakhq[bot] merged 1 commit intovercel:canaryfrom
shuding:shu/48ce
Mar 1, 2022
Merged

Optimize component type filters#34941
kodiakhq[bot] merged 1 commit intovercel:canaryfrom
shuding:shu/48ce

Conversation

@shuding
Copy link
Copy Markdown
Member

@shuding shuding commented Mar 1, 2022

Since we are applying this loader to more files, and these two simple RegExp filters will be executed ~70 times per entry, it's an easy optimization to move the RegExp creation outside and merge related testers into the RegExp.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Mar 1, 2022
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Mar 1, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary shuding/next.js shu/48ce Change
buildDuration 15.5s 15.6s ⚠️ +64ms
buildDurationCached 6.2s 6.1s -72ms
nodeModulesSize 372 MB 372 MB -438 B
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/48ce Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.959 2.951 -0.01
/ avg req/sec 844.78 847.2 +2.42
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.222 1.219 0
/error-in-render avg req/sec 2045.46 2050.32 +4.86
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/48ce Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 27.9 kB 27.9 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.5 kB 71.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/48ce Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/48ce Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.57 kB 2.57 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 5.05 kB 5.05 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/48ce Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/48ce Change
index.html gzip 531 B 531 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary shuding/next.js shu/48ce Change
buildDuration 18.6s 18.6s -20ms
buildDurationCached 6.1s 6s -73ms
nodeModulesSize 372 MB 372 MB -438 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/48ce Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.972 2.954 -0.02
/ avg req/sec 841.23 846.32 +5.09
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.181 1.215 ⚠️ +0.03
/error-in-render avg req/sec 2116.31 2057.03 ⚠️ -59.28
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/48ce Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.1 kB 28.1 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.1 kB 72.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/48ce Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/48ce Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 313 B 313 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.56 kB 2.56 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.2 kB 5.2 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.33 kB 2.33 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.9 kB 14.9 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/48ce Change
_buildManifest.js gzip 456 B 456 B ✓
Overall change 456 B 456 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/48ce Change
index.html gzip 530 B 530 B ✓
link.html gzip 543 B 543 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 1cf2592

@kodiakhq kodiakhq Bot merged commit 9c0c93e into vercel:canary Mar 1, 2022
@shuding shuding deleted the shu/48ce branch March 2, 2022 00:25
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@padmaia padmaia Awaiting requested review from padmaia

@huozhi huozhi Awaiting requested review from huozhi

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shuding @ijjk