Skip to content

Provide page runtime parsing utils#34922

Merged
ijjk merged 7 commits intovercel:canaryfrom
huozhi:parse-page-runtime
Mar 2, 2022
Merged

Provide page runtime parsing utils#34922
ijjk merged 7 commits intovercel:canaryfrom
huozhi:parse-page-runtime

Conversation

@huozhi
Copy link
Copy Markdown
Contributor

@huozhi huozhi commented Mar 1, 2022 •
edited
Loading

x-ref: #31317

Adding utils for parsing page runtime and map runtime values with page mappings. Then later we could use it for detecting runtime of each entry.
Give the swc utils a dummy declaration to use with typescript easier

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • unit tests added

@ijjk ijjk added examples Issue was opened via the examples template. created-by: Next.js team PRs by the Next.js team. type: next labels Mar 1, 2022
@huozhi huozhi force-pushed the parse-page-runtime branch from ad31a46 to 748549a Compare March 1, 2022 16:26
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@huozhi huozhi marked this pull request as ready for review March 1, 2022 16:58
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Mar 1, 2022

Failing test suites

Commit: 6a9e5eb76c9661cc3f6a736b2d64e6d1925d5e1c

yarn testheadless test/integration/image-component/default/test/index.test.js

  • Image Component Tests > dev mode > should warn at most once even after state change
Expand output

● Image Component Tests › dev mode › should warn at most once even after state change

expect(received).toMatch(expected)

Matcher error: received value must be a string

Received has value: undefined

  838 |         'Image with src "/test.png" has "sizes" property but it will be ignored.'
  839 |       )
> 840 |       expect(warnings[1]).toMatch(
      |                           ^
  841 |         'Image with src "/test.png" was detected as the Largest Contentful Paint (LCP).'
  842 |       )
  843 |       expect(warnings.length).toBe(2)

  at Object.<anonymous> (integration/image-component/default/test/index.test.js:840:27)

Read more about building and testing Next.js in contributing.md.

@ijjk

This comment has been minimized.

Sign in to view
shuding
shuding reviewed Mar 1, 2022
View reviewed changes
Comment thread examples/hello-world/pages/index.js Outdated
shuding
shuding reviewed Mar 2, 2022
View reviewed changes
Comment thread packages/next/build/entries.ts Outdated
@huozhi huozhi force-pushed the parse-page-runtime branch from 6a9e5eb to ddb6613 Compare March 2, 2022 13:03
@huozhi huozhi requested review from shuding and removed request for leerob and steven-tey March 2, 2022 13:09
@huozhi huozhi removed the examples Issue was opened via the examples template. label Mar 2, 2022
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Mar 2, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js parse-page-runtime Change
buildDuration 15.3s 15.5s ⚠️ +208ms
buildDurationCached 6.2s 6s -122ms
nodeModulesSize 372 MB 372 MB ⚠️ +5.92 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js parse-page-runtime Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.912 2.906 -0.01
/ avg req/sec 858.63 860.3 +1.67
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.171 1.176 0
/error-in-render avg req/sec 2135.67 2126.56 ⚠️ -9.11
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js parse-page-runtime Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 27.9 kB 27.9 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.5 kB 71.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js parse-page-runtime Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js parse-page-runtime Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 192 B 192 B ✓
amp-HASH.js gzip 309 B 309 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.57 kB 2.57 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.05 kB 5.05 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js parse-page-runtime Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js parse-page-runtime Change
index.html gzip 533 B 533 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js parse-page-runtime Change
buildDuration 18.2s 18.5s ⚠️ +295ms
buildDurationCached 6.2s 6s -211ms
nodeModulesSize 372 MB 372 MB ⚠️ +5.92 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js parse-page-runtime Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.925 2.917 -0.01
/ avg req/sec 854.57 857.07 +2.5
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.207 1.187 -0.02
/error-in-render avg req/sec 2071.26 2106.95 +35.69
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js parse-page-runtime Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.1 kB 28.1 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.1 kB 72.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js parse-page-runtime Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js parse-page-runtime Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 313 B 313 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.56 kB 2.56 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.2 kB 5.2 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.33 kB 2.33 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 388 B 388 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.9 kB 14.9 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js parse-page-runtime Change
_buildManifest.js gzip 456 B 456 B ✓
Overall change 456 B 456 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js parse-page-runtime Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 49c78be

@ijjk ijjk merged commit d9d494a into vercel:canary Mar 2, 2022
@huozhi huozhi deleted the parse-page-runtime branch March 2, 2022 21:01
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shuding shuding shuding approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@padmaia padmaia Awaiting requested review from padmaia

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huozhi @ijjk @shuding