Skip to content

Fix only byte stream writing is allowed in CF workers#34893

Merged
kodiakhq[bot] merged 5 commits intovercel:canaryfrom
huozhi:fix/cf-streaming-write
Feb 28, 2022
Merged

Fix only byte stream writing is allowed in CF workers#34893
kodiakhq[bot] merged 5 commits intovercel:canaryfrom
huozhi:fix/cf-streaming-write

Conversation

@huozhi
Copy link
Copy Markdown
Contributor

@huozhi huozhi commented Feb 28, 2022 •
edited
Loading

CF worker doesn't allow to use writer.write(string) but only byte stream, we have to transform the Uint8Array stream

image

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 28, 2022
@ijjk

This comment was marked as outdated.

Sign in to view
@huozhi huozhi force-pushed the fix/cf-streaming-write branch from d86d1ff to ce40f8c Compare February 28, 2022 19:46
@ijjk

This comment has been minimized.

Sign in to view
@huozhi huozhi marked this pull request as ready for review February 28, 2022 21:28
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Feb 28, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js fix/cf-streaming-write Change
buildDuration 18.4s 19s ⚠️ +558ms
buildDurationCached 7.2s 7.3s ⚠️ +99ms
nodeModulesSize 368 MB 368 MB -655 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/cf-streaming-write Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.881 3.97 ⚠️ +0.09
/ avg req/sec 644.12 629.77 ⚠️ -14.35
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.072 2.059 -0.01
/error-in-render avg req/sec 1206.85 1214.32 +7.47
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js fix/cf-streaming-write Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 27.8 kB 27.8 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.5 kB 71.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/cf-streaming-write Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js fix/cf-streaming-write Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.57 kB 2.57 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 5.05 kB 5.05 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/cf-streaming-write Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/cf-streaming-write Change
index.html gzip 532 B 532 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js fix/cf-streaming-write Change
buildDuration 23s 23s ⚠️ +1ms
buildDurationCached 7s 7.1s ⚠️ +135ms
nodeModulesSize 368 MB 368 MB -655 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js fix/cf-streaming-write Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.831 3.976 ⚠️ +0.15
/ avg req/sec 652.65 628.7 ⚠️ -23.95
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.14 2.081 -0.06
/error-in-render avg req/sec 1168.37 1201.15 +32.78
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js fix/cf-streaming-write Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.1 kB 42.1 kB ✓
main-HASH.js gzip 27.9 kB 27.9 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.6 kB 71.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/cf-streaming-write Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js fix/cf-streaming-write Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.56 kB 2.56 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 5.08 kB 5.08 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.28 kB 2.28 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/cf-streaming-write Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/cf-streaming-write Change
index.html gzip 534 B 534 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: 876763c

@kodiakhq kodiakhq Bot merged commit 8e3b6fc into vercel:canary Feb 28, 2022
@shuding shuding deleted the fix/cf-streaming-write branch March 1, 2022 12:18
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shuding shuding shuding approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huozhi @ijjk @shuding