Skip to content

fix(Script): allow passing defer=false to Script component#34850

Merged
kodiakhq[bot] merged 4 commits intovercel:canaryfrom
chentsulin:disable-defer
Mar 11, 2022
Merged

fix(Script): allow passing defer=false to Script component#34850
kodiakhq[bot] merged 4 commits intovercel:canaryfrom
chentsulin:disable-defer

Conversation

@chentsulin
Copy link
Copy Markdown
Contributor

@chentsulin chentsulin commented Feb 26, 2022 •
edited
Loading

Bug

<Script
  async
  defer={false}
  strategy='beforeInteractive'
  src='https://securepubads.g.doubleclick.net/tag/js/gpt.js'
/>

output:

<script src="https://securepubads.g.doubleclick.net/tag/js/gpt.js" async="" defer="" data-nscript="beforeInteractive"></script>

The defer prop is overridden by !disableOptimizedLoading, so can't disable it on the particular script.

@ijjk

This comment has been minimized.

Sign in to view
@balazsorban44
Copy link
Copy Markdown
Contributor

balazsorban44 commented Feb 27, 2022

Related #33686

timneutkens
timneutkens reviewed Feb 28, 2022
View reviewed changes
Comment thread packages/next/pages/_document.tsx
{...scriptProps}
key={scriptProps.src || index}
defer={!disableOptimizedLoading}
defer={scriptProps.defer ?? !disableOptimizedLoading}
Copy link
Copy Markdown
Contributor

@timneutkens timneutkens Feb 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janicklas-ralph can you review this. It looks fine to me.

Copy link
Copy Markdown
Contributor Author

@chentsulin chentsulin Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timneutkens Is there any chance to get this moving forward? We can't migrate to Script components because of this issue.

Copy link
Copy Markdown
Contributor

@housseindjirdeh housseindjirdeh Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We can merge this as soon as possible.

@ijjk ijjk requested a review from janicklas-ralph March 11, 2022 01:40
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Mar 11, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary chentsulin/next.js disable-defer Change
buildDuration 20.8s 20.2s -612ms
buildDurationCached 8s 7.8s -194ms
nodeModulesSize 378 MB 378 MB ⚠️ +165 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary chentsulin/next.js disable-defer Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.451 4.389 -0.06
/ avg req/sec 561.67 569.62 +7.95
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.249 2.372 ⚠️ +0.12
/error-in-render avg req/sec 1111.43 1053.75 ⚠️ -57.68
Client Bundles (main, webpack)
vercel/next.js canary chentsulin/next.js disable-defer Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 27.9 kB 27.9 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.6 kB 71.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary chentsulin/next.js disable-defer Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary chentsulin/next.js disable-defer Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 192 B 192 B ✓
amp-HASH.js gzip 309 B 309 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.57 kB 2.57 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.09 kB 5.09 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.8 kB 14.8 kB ✓
Client Build Manifests
vercel/next.js canary chentsulin/next.js disable-defer Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary chentsulin/next.js disable-defer Change
index.html gzip 530 B 530 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 524 B 524 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary chentsulin/next.js disable-defer Change
buildDuration 25.1s 25s -65ms
buildDurationCached 7.9s 7.9s -20ms
nodeModulesSize 378 MB 378 MB ⚠️ +165 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary chentsulin/next.js disable-defer Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.276 4.323 ⚠️ +0.05
/ avg req/sec 584.69 578.27 ⚠️ -6.42
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.167 2.165 0
/error-in-render avg req/sec 1153.9 1154.98 +1.08
Client Bundles (main, webpack)
vercel/next.js canary chentsulin/next.js disable-defer Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.2 kB 28.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.2 kB 72.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary chentsulin/next.js disable-defer Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary chentsulin/next.js disable-defer Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 313 B 313 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.56 kB 2.56 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.23 kB 5.23 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.33 kB 2.33 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 388 B 388 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15 kB 15 kB ✓
Client Build Manifests
vercel/next.js canary chentsulin/next.js disable-defer Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary chentsulin/next.js disable-defer Change
index.html gzip 531 B 531 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 0840ae8

@kodiakhq kodiakhq Bot merged commit bc0816f into vercel:canary Mar 11, 2022
@chentsulin chentsulin deleted the disable-defer branch March 12, 2022 09:08
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens timneutkens left review comments

@ijjk ijjk ijjk approved these changes

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@janicklas-ralph janicklas-ralph Awaiting requested review from janicklas-ralph

+1 more reviewer

@housseindjirdeh housseindjirdeh housseindjirdeh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chentsulin @ijjk @balazsorban44 @timneutkens @housseindjirdeh