fix eslint-plugin-react version to avoid jsx-key error by thibautsabot · Pull Request #34800 · vercel/next.js

thibautsabot · 2022-02-25T09:23:41Z

Context: https://github.com/yannickcr/eslint-plugin-react was released in 7.29.0 2h ago and breaks the linting of a default create-next-app.

See: jsx-eslint/eslint-plugin-react#3215

This PR locks the version to the latest working one.

cizz3007 · 2022-02-25T09:32:28Z

it's too critical issue i guess..

ijjk · 2022-02-25T09:42:56Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	thibautsabot/next.js fix-eslint-plugin-react-version	Change
buildDuration	18s	18.3s	⚠️ +263ms
buildDurationCached	7.1s	7.1s	-10ms
nodeModulesSize	367 MB	367 MB	-7 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	thibautsabot/next.js fix-eslint-plugin-react-version	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.415	3.475	⚠️ +0.06
/ avg req/sec	732.17	719.43	⚠️ -12.74
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.554	1.589	⚠️ +0.03
/error-in-render avg req/sec	1608.93	1572.94	⚠️ -35.99

Client Bundles (main, webpack)

	vercel/next.js canary	thibautsabot/next.js fix-eslint-plugin-react-version	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	27.8 kB	27.8 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.5 kB	71.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	thibautsabot/next.js fix-eslint-plugin-react-version	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	thibautsabot/next.js fix-eslint-plugin-react-version	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.57 kB	2.57 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	5.05 kB	5.05 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.26 kB	2.26 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.7 kB	14.7 kB	✓

Client Build Manifests

	vercel/next.js canary	thibautsabot/next.js fix-eslint-plugin-react-version	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	thibautsabot/next.js fix-eslint-plugin-react-version	Change
index.html gzip	531 B	531 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	thibautsabot/next.js fix-eslint-plugin-react-version	Change
buildDuration	22.1s	22s	-104ms
buildDurationCached	7.2s	7.1s	-158ms
nodeModulesSize	367 MB	367 MB	-7 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	thibautsabot/next.js fix-eslint-plugin-react-version	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.472	3.514	⚠️ +0.04
/ avg req/sec	720	711.45	⚠️ -8.55
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.613	1.751	⚠️ +0.14
/error-in-render avg req/sec	1549.55	1427.85	⚠️ -121.7

Client Bundles (main, webpack)

	vercel/next.js canary	thibautsabot/next.js fix-eslint-plugin-react-version	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.1 kB	42.1 kB	✓
main-HASH.js gzip	27.8 kB	27.8 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.6 kB	71.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	thibautsabot/next.js fix-eslint-plugin-react-version	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	thibautsabot/next.js fix-eslint-plugin-react-version	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.56 kB	2.56 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	911 B	911 B	✓
image-HASH.js gzip	5.08 kB	5.08 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.28 kB	2.28 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.7 kB	14.7 kB	✓

Client Build Manifests

	vercel/next.js canary	thibautsabot/next.js fix-eslint-plugin-react-version	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	thibautsabot/next.js fix-eslint-plugin-react-version	Change
index.html gzip	534 B	534 B	✓
link.html gzip	547 B	547 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.61 kB	1.61 kB	✓

Commit: 99e691d

timneutkens

We'll probably want to lock versions for all deps @housseindjirdeh

briantuju · 2022-02-25T12:30:52Z

Also, anyone who's encountering production builds failing due to this error, you can follow the instructions from here

…l#34800)" This reverts commit 99713ba.

irfanullahjan · 2022-02-26T01:57:58Z

I had to delete the lock file, then npm i and then also had to delete .next and then my production build went fine. So there's no need to disable Eslint at next build stage. They have fixed the issue in eslint-plugin-react@7.29.1

fix eslint-plugin-react version to avoid jsx-key error

99e691d

thibautsabot requested review from huozhi, ijjk, shuding and timneutkens as code owners February 25, 2022 09:23

ijjk added the type: next label Feb 25, 2022

timneutkens approved these changes Feb 25, 2022

View reviewed changes

kodiakhq Bot merged commit 99713ba into vercel:canary Feb 25, 2022

timneutkens mentioned this pull request Feb 25, 2022

ESlint error on build (even with starter template) #34798

Closed

1 task

meeroslav mentioned this pull request Feb 25, 2022

chore(react): fix version on eslint-plugin-react nrwl/nx#9121

Merged

ijjk mentioned this pull request Feb 25, 2022

lock eslint-config-next dependencies #34823

Merged

vagusX mentioned this pull request Feb 26, 2022

fix: remove lock for eslint-plugin-react in eslint-config-next #34837

Closed

vagusX added a commit to vagusX/next.js that referenced this pull request Feb 26, 2022

Revert "fix eslint-plugin-react version to avoid jsx-key error (verce…

3b6b3da

…l#34800)" This reverts commit 99713ba.

arghav mentioned this pull request Mar 24, 2022

chore: fix eslint config team-telnyx/telnyx-meet#60

Merged

1 task

github-actions Bot locked as resolved and limited conversation to collaborators Mar 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix eslint-plugin-react version to avoid jsx-key error#34800

fix eslint-plugin-react version to avoid jsx-key error#34800
kodiakhq[bot] merged 1 commit intovercel:canaryfrom
thibautsabot:fix-eslint-plugin-react-version

thibautsabot commented Feb 25, 2022

Uh oh!

cizz3007 commented Feb 25, 2022

Uh oh!

ijjk commented Feb 25, 2022

Uh oh!

timneutkens left a comment

Uh oh!

briantuju commented Feb 25, 2022

Uh oh!

irfanullahjan commented Feb 26, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

thibautsabot commented Feb 25, 2022

Uh oh!

cizz3007 commented Feb 25, 2022

Uh oh!

ijjk commented Feb 25, 2022

Stats from current PR

Uh oh!

timneutkens left a comment

Choose a reason for hiding this comment

Uh oh!

briantuju commented Feb 25, 2022

Uh oh!

irfanullahjan commented Feb 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

irfanullahjan commented Feb 26, 2022 •

edited

Loading