Skip to content

feat: allow dotenv default expansion#34765

Merged
kodiakhq[bot] merged 7 commits intocanaryfrom
feat/allow-dotenv-expand
Mar 3, 2022
Merged

feat: allow dotenv default expansion#34765
kodiakhq[bot] merged 7 commits intocanaryfrom
feat/allow-dotenv-expand

Conversation

@balazsorban44
Copy link
Copy Markdown
Contributor

@balazsorban44 balazsorban44 commented Feb 24, 2022

We currently use dotenv-expand@5 in @next/env, which does not support default expansion. It was added in v6 (motdotla/dotenv-expand#39).

Upgrading to the latest version of dotenv-expand and fixing an import, the added test passed.

Fixes #34718

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

Sign in to view
timneutkens
timneutkens approved these changes Feb 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👍

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@kodiakhq kodiakhq Bot merged commit 728d826 into canary Mar 3, 2022
@kodiakhq kodiakhq Bot deleted the feat/allow-dotenv-expand branch March 3, 2022 16:52
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Mar 3, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feat/allow-dotenv-expand Change
buildDuration 15.4s 15.7s ⚠️ +242ms
buildDurationCached 6.2s 6.1s -88ms
nodeModulesSize 372 MB 372 MB ⚠️ +155 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js feat/allow-dotenv-expand Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.948 2.942 -0.01
/ avg req/sec 848.06 849.71 +1.65
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.192 1.198 ⚠️ +0.01
/error-in-render avg req/sec 2097.42 2086 ⚠️ -11.42
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js feat/allow-dotenv-expand Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 27.9 kB 27.9 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.5 kB 71.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feat/allow-dotenv-expand Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js feat/allow-dotenv-expand Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 192 B 192 B ✓
amp-HASH.js gzip 309 B 309 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.57 kB 2.57 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.06 kB 5.06 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.8 kB 14.8 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js feat/allow-dotenv-expand Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js feat/allow-dotenv-expand Change
index.html gzip 532 B 532 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feat/allow-dotenv-expand Change
buildDuration 18.7s 18.5s -179ms
buildDurationCached 6.1s 6s -58ms
nodeModulesSize 372 MB 372 MB ⚠️ +155 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js feat/allow-dotenv-expand Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.92 2.916 0
/ avg req/sec 856.15 857.39 +1.24
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.173 1.195 ⚠️ +0.02
/error-in-render avg req/sec 2130.45 2092.27 ⚠️ -38.18
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js feat/allow-dotenv-expand Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.1 kB 28.1 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.1 kB 72.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feat/allow-dotenv-expand Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js feat/allow-dotenv-expand Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 313 B 313 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.56 kB 2.56 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.2 kB 5.2 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.33 kB 2.33 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 388 B 388 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.9 kB 14.9 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js feat/allow-dotenv-expand Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js feat/allow-dotenv-expand Change
index.html gzip 530 B 530 B ✓
link.html gzip 543 B 543 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 2838024

@FezVrasta
Copy link
Copy Markdown

FezVrasta commented Mar 29, 2022 •
edited
Loading

Has this been published already? The latest next.js version doesn't seem to support this yet. Not even 12.1.3-canary.0 seems to include the change.

@FezVrasta
Copy link
Copy Markdown

FezVrasta commented Mar 29, 2022

Actually, I see the updated dotenv-expand version on 12.1.2 (https://unpkg.com/browse/@next/env@12.1.2/package.json) but it's not working. May someone confirm please?

@hckhanh
Copy link
Copy Markdown

hckhanh commented Apr 2, 2022

Me too, I come here from the #35818

@FezVrasta
Copy link
Copy Markdown

FezVrasta commented Apr 2, 2022

It looks like dotenv-expand has a bug. I fixed it here but nobody from the maintainers replied yet.

motdotla/dotenv-expand#74

@MattIPv4
Copy link
Copy Markdown
Contributor

MattIPv4 commented Apr 18, 2022

This also introduced motdotla/dotenv-expand#65 to env parsing

@balazsorban44 balazsorban44 mentioned this pull request May 5, 2022
Closed
1 task
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees

No one assigned

Labels

type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dotenv-expand' "default" expansion not working

6 participants

@balazsorban44 @ijjk @FezVrasta @hckhanh @MattIPv4 @timneutkens