Remove page-specific font example from docs#34694
Merged
kodiakhq[bot] merged 1 commit intovercel:canaryfrom Feb 22, 2022
Merged
Remove page-specific font example from docs#34694kodiakhq[bot] merged 1 commit intovercel:canaryfrom
kodiakhq[bot] merged 1 commit intovercel:canaryfrom
Conversation
The Font Optimization docs have an outdated example that recommends adding fonts via `next/head`. This is an anti-pattern that Next.js has already warned about through ESLint for a while (see https://nextjs.org/docs/messages/no-page-custom-font) and is now starting to warn about through the console because it won't work well with streaming architecture. This change removes the outdated example from the docs. Fixes vercel#34693
styfle
approved these changes
Feb 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Font Optimization docs have an outdated example that recommends
adding fonts via
next/head. This is an anti-pattern that Next.jshas already warned about through ESLint for a while (see
https://nextjs.org/docs/messages/no-page-custom-font) and is now
starting to warn about through the console because it won't work
well with streaming architecture.
This change removes the outdated example from the docs.
Fixes #34693
Documentation / Examples
yarn lint