Skip to content

removing redundant/unnecessary lines as these are defaults#34587

Merged
kodiakhq[bot] merged 2 commits intovercel:canaryfrom
theabgarg:patch-1
Feb 21, 2022
Merged

removing redundant/unnecessary lines as these are defaults#34587
kodiakhq[bot] merged 2 commits intovercel:canaryfrom
theabgarg:patch-1

Conversation

@theabgarg
Copy link
Copy Markdown
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue was opened via the examples template. label Feb 19, 2022
Copy link
Copy Markdown
Contributor

@nrjdalal nrjdalal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personal preferences are subjective and are not required, also these are the defaults

@kodiakhq kodiakhq Bot merged commit 5a16b1a into vercel:canary Feb 21, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

examples Issue was opened via the examples template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants