Skip to content

Allow reading request bodies in middlewares#34294

Merged
kodiakhq[bot] merged 7 commits intovercel:canaryfrom
Schniz:read-json-body
Feb 17, 2022
Merged

Allow reading request bodies in middlewares#34294
kodiakhq[bot] merged 7 commits intovercel:canaryfrom
Schniz:read-json-body

Conversation

@Schniz
Copy link
Copy Markdown
Contributor

@Schniz Schniz commented Feb 13, 2022 •
edited
Loading

Schniz
Schniz commented Feb 13, 2022
View reviewed changes
Comment thread packages/next/package.json Outdated
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@Schniz Schniz marked this pull request as ready for review February 14, 2022 13:14
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Feb 14, 2022

Failing test suites

Commit: 04177b8cc3b0213251b3feea421cfa30e1abb91e

yarn testheadless test/integration/ondemand/test/index.test.js

  • On Demand Entries > should navigate to pages with dynamic imports
Expand output

● On Demand Entries › should navigate to pages with dynamic imports

TIMED OUT: /Hello/

/nav/dynamic

  474 |
  475 |   if (hardError) {
> 476 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  477 |   }
  478 |   return false
  479 | }

  at Object.check (lib/next-test-utils.js:476:11)
  at Object.<anonymous> (integration/ondemand/test/index.test.js:128:7)

Read more about building and testing Next.js in contributing.md.

ijjk
ijjk reviewed Feb 14, 2022
View reviewed changes
Comment thread test/production/reading-request-body-in-middleware/index.test.ts Outdated
Copy link
Copy Markdown
Member

@ijjk ijjk Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test case where the middleware reads the body but then continues to an API route that returns the body from req.body?

Copy link
Copy Markdown
Contributor Author

@Schniz Schniz Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

Copy link
Copy Markdown
Contributor Author

@Schniz Schniz Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🚀 ⏲️

@Schniz Schniz marked this pull request as draft February 15, 2022 11:13
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
Schniz
Schniz commented Feb 15, 2022
View reviewed changes
Comment thread packages/next/server/next-server.ts Outdated
@Schniz Schniz marked this pull request as ready for review February 15, 2022 16:22
@Schniz Schniz requested a review from ijjk February 15, 2022 16:22
@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk requested a review from javivelasco February 15, 2022 19:14
This was referenced Feb 19, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Merged
Merged
This was referenced Feb 28, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@pettinarip pettinarip mentioned this pull request Mar 18, 2022
Merged
5 tasks
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@huozhi huozhi huozhi approved these changes

@javivelasco javivelasco javivelasco left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@ijjk ijjk Awaiting requested review from ijjk

Assignees

No one assigned

Labels

type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Middleware in API have a null body on POST Requests

4 participants

@Schniz @ijjk @javivelasco @huozhi