Skip to content

Improve tests for streaming and server components#33740

Merged
kodiakhq[bot] merged 4 commits intovercel:canaryfrom
shuding:shu/d79f
Jan 27, 2022
Merged

Improve tests for streaming and server components#33740
kodiakhq[bot] merged 4 commits intovercel:canaryfrom
shuding:shu/d79f

Conversation

@shuding
Copy link
Copy Markdown
Member

@shuding shuding commented Jan 27, 2022

Reorganizes the existing tests as they're getting longer.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Jan 27, 2022
@ijjk

This comment has been minimized.

Sign in to view
@shuding shuding requested a review from padmaia as a code owner January 27, 2022 16:01
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Jan 27, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/d79f Change
buildDuration 12.3s 12.3s ⚠️ +47ms
buildDurationCached 3.2s 3.2s ⚠️ +31ms
nodeModulesSize 358 MB 358 MB ⚠️ +7 B
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/d79f Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.916 2.922 ⚠️ +0.01
/ avg req/sec 857.3 855.69 ⚠️ -1.61
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.35 1.318 -0.03
/error-in-render avg req/sec 1851.47 1896.48 +45.01
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/d79f Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71 kB 71 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/d79f Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/d79f Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.94 kB 4.94 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.4 kB 14.4 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/d79f Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/d79f Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/d79f Change
buildDuration 15.5s 15.7s ⚠️ +136ms
buildDurationCached 3.2s 3.2s ✓
nodeModulesSize 358 MB 358 MB ⚠️ +7 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/d79f Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.869 2.919 ⚠️ +0.05
/ avg req/sec 871.33 856.41 ⚠️ -14.92
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.343 1.364 ⚠️ +0.02
/error-in-render avg req/sec 1862.04 1832.39 ⚠️ -29.65
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/d79f Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.3 kB 27.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.3 kB 71.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/d79f Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/d79f Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 4.97 kB 4.97 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.21 kB 2.21 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.3 kB 14.3 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/d79f Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/d79f Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 92341ed

@kodiakhq kodiakhq Bot merged commit 66af3ce into vercel:canary Jan 27, 2022
@shuding shuding deleted the shu/d79f branch January 27, 2022 17:59
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@huozhi huozhi huozhi approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@padmaia padmaia Awaiting requested review from padmaia

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shuding @ijjk @huozhi