Skip to content

Update Time to First Byte (TTFB) link#33715

Merged
kodiakhq[bot] merged 2 commits intovercel:canaryfrom
Vienio99:patch-1
Jan 26, 2022
Merged

Update Time to First Byte (TTFB) link#33715
kodiakhq[bot] merged 2 commits intovercel:canaryfrom
Vienio99:patch-1

Conversation

@Vienio99
Copy link
Copy Markdown
Contributor

The initial link was showing 404 not found

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

The initial link was showing 404 not found
Copy link
Copy Markdown
Contributor

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link looks correct to me https://nextjs.org/learn/seo/web-performance

It just needs to be an absolute URL since its not under /docs, its under /learn

Comment thread docs/basic-features/data-fetching/get-server-side-props.md Outdated
Copy link
Copy Markdown
Contributor

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq Bot merged commit a0275f2 into vercel:canary Jan 26, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants