[docs] Update authentication docs to fix iron-session link.#33483
Merged
timneutkens merged 3 commits intovercel:canaryfrom Jan 21, 2022
tharakabimal:patch-1
Merged
[docs] Update authentication docs to fix iron-session link.#33483timneutkens merged 3 commits intovercel:canaryfrom tharakabimal:patch-1
timneutkens merged 3 commits intovercel:canaryfrom
tharakabimal:patch-1
Conversation
example links updated.
balazsorban44
suggested changes
Jan 20, 2022
Contributor
There was a problem hiding this comment.
Why are the two changes the opposite of each other?
The repo's README shows the current URL as https://iron-session-example.vercel.app, not the one you recommend. 🤔
@vvo could you verify which one is correct?
Member
|
Hey, there the right url is https://iron-session-example.vercel.app/ yes. It was previously a different URL but I decided to link directly to the source (the iron session GitHub example). @tharakabimal may I ask you what triggered your will to change? Thanks! |
Contributor
Author
vvo
added a commit
to vvo/next.js
that referenced
this pull request
Jan 20, 2022
Following comment here: vercel#33483 (comment)
1 task
vvo
reviewed
Jan 20, 2022
vvo
requested changes
Jan 20, 2022
Member
vvo
left a comment
There was a problem hiding this comment.
You can accept the request changes
Co-authored-by: Vincent Voyer <vincent@codeagain.com>
leerob
approved these changes
Jan 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched the example links
Bug
fixes #numbercontributing.mdFeature
fixes #numbercontributing.mdDocumentation / Examples
yarn lint