Skip to content

Changed data fetching file name to overview to fix meta data title#33232

Merged
ijjk merged 6 commits intovercel:canaryfrom
molebox:fix-data-fetching-meta-data
Jan 27, 2022
Merged

Changed data fetching file name to overview to fix meta data title#33232
ijjk merged 6 commits intovercel:canaryfrom
molebox:fix-data-fetching-meta-data

Conversation

@molebox
Copy link
Copy Markdown
Contributor

@molebox molebox commented Jan 12, 2022 •
edited by balazsorban44
Loading

This PR aims to fix the meta data title on og images by changing the file path name from index to overview. It also fixes all links to this path and adds a redirect on the route

fixes #33522

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

leerob
leerob previously approved these changes Jan 12, 2022
View reviewed changes
styfle
styfle reviewed Jan 15, 2022
View reviewed changes
Comment thread docs/api-reference/data-fetching/get-server-side-props.md Outdated
@balazsorban44 balazsorban44 mentioned this pull request Jan 21, 2022
Closed
@molebox
Copy link
Copy Markdown
Contributor Author

molebox commented Jan 21, 2022

@styfle would you mind taking another look here please, and merging if all 🟢

ijjk
ijjk previously approved these changes Jan 21, 2022
View reviewed changes
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Jan 21, 2022

It looks like the manifest needs to be updated still https://github.com/vercel/next.js/runs/4896213283?check_suite_focus=true

@molebox
Copy link
Copy Markdown
Contributor Author

molebox commented Jan 25, 2022

It looks like the manifest needs to be updated still https://github.com/vercel/next.js/runs/4896213283?check_suite_focus=true

Thanks @ijjk I confused how this works. This is the snippet:

            {
              "title": "Data Fetching",
              "path": "/docs/basic-features/data-fetching/index.md",
              "redirect": {
                "destination": "/docs/basic-features/data-fetching/overview.md",
                "permanent": true
              },

Do i change the original path to point to overview.md too?

@ijjk
Copy link
Copy Markdown
Member

ijjk commented Jan 27, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary molebox/next.js fix-data-fetching-meta-data Change
buildDuration 12.7s 12.6s -65ms
buildDurationCached 3.2s 3.2s -32ms
nodeModulesSize 356 MB 356 MB ⚠️ +14 B
Page Load Tests Overall increase ✓
vercel/next.js canary molebox/next.js fix-data-fetching-meta-data Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.945 2.929 -0.02
/ avg req/sec 848.94 853.62 +4.68
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.399 1.376 -0.02
/error-in-render avg req/sec 1787.39 1816.75 +29.36
Client Bundles (main, webpack, commons)
vercel/next.js canary molebox/next.js fix-data-fetching-meta-data Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71 kB 71 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary molebox/next.js fix-data-fetching-meta-data Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary molebox/next.js fix-data-fetching-meta-data Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.94 kB 4.94 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.4 kB 14.4 kB ✓
Client Build Manifests
vercel/next.js canary molebox/next.js fix-data-fetching-meta-data Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary molebox/next.js fix-data-fetching-meta-data Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary molebox/next.js fix-data-fetching-meta-data Change
buildDuration 16s 16.4s ⚠️ +446ms
buildDurationCached 3.3s 3.2s -83ms
nodeModulesSize 356 MB 356 MB ⚠️ +14 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary molebox/next.js fix-data-fetching-meta-data Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.906 2.914 ⚠️ +0.01
/ avg req/sec 860.25 857.93 ⚠️ -2.32
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.392 1.398 ⚠️ +0.01
/error-in-render avg req/sec 1795.42 1788.82 ⚠️ -6.6
Client Bundles (main, webpack, commons)
vercel/next.js canary molebox/next.js fix-data-fetching-meta-data Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.3 kB 27.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.3 kB 71.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary molebox/next.js fix-data-fetching-meta-data Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary molebox/next.js fix-data-fetching-meta-data Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 4.97 kB 4.97 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.21 kB 2.21 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.3 kB 14.3 kB ✓
Client Build Manifests
vercel/next.js canary molebox/next.js fix-data-fetching-meta-data Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary molebox/next.js fix-data-fetching-meta-data Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 9b224de

@ijjk ijjk merged commit 8a1c947 into vercel:canary Jan 27, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

+2 more reviewers

@styfle styfle styfle left review comments

@leerob leerob leerob left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs: Web SDK section broken

4 participants

@molebox @ijjk @styfle @leerob