Skip to content

Add Caveats section to custom error page#33160

Merged
kodiakhq[bot] merged 2 commits intovercel:canaryfrom
glenngijsberts:glenn/patch
Jan 10, 2022
Merged

Add Caveats section to custom error page#33160
kodiakhq[bot] merged 2 commits intovercel:canaryfrom
glenngijsberts:glenn/patch

Conversation

@glenngijsberts
Copy link
Copy Markdown
Contributor

Desscription

This is a follow up of #32873. As discussed in #32873, currently it's not recommended to use getServerSideProps in the Error component, so this PR will add that caveat to the documentation page, like Document and App also have.

Documentation / Examples

  • Make sure the linting passes by running yarn lint

This is a follow up of #32873. As discussed in #32873, currently it's not recommended to use getServerSideProps in the `Error` component, so this commit will add that caveat to the page, like `Document` and `App` also have.
Copy link
Copy Markdown
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq Bot merged commit 5f4947e into vercel:canary Jan 10, 2022
teleaziz added a commit to teleaziz/next.js that referenced this pull request Jan 11, 2022
…into cms-builder-io-example

* 'cms-builder-io-example' of github.com:teleaziz/next.js: (22 commits)
  drop dynamic import with `ssr: false` on server-side (vercel#32606)
  next-swc: fix ssg code elimination when used in render (vercel#32709)
  Add Caveats section to custom error page (vercel#33160)
  v12.0.8-canary.20
  Allow dependencies to use environment variables in middlewares (vercel#33141)
  use a separate webpack runtime for middleware (vercel#33134)
  No info on environment variables in the src folder (vercel#33110) (vercel#33136)
  docs: minor text-copy cleanup (vercel#33120)
  Update swc (vercel#33063)
  Update next.config.js (vercel#33091)
  Adding Asset Component for Rich Text Renderer (vercel#32503)
  Update using-mdx.md (vercel#33077)
  v12.0.8-canary.19
  Fix middleware at root in standalone mode (vercel#33053)
  Add util for generating new tests/error documents (vercel#33001)
  Remove extra config from tailwind example (vercel#33062)
  Fix link for Next.js Analytics in docs (vercel#33049)
  Bump `@vercel/nft` to 0.17.2 (vercel#33048)
  Update deployment documentation. (vercel#32006)
  v12.0.8-canary.18
  ...
@glenngijsberts glenngijsberts deleted the glenn/patch branch January 12, 2022 21:14
@vercel vercel locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants