Add onLoad gottcha note to next/script docs#33097
Merged
kodiakhq[bot] merged 4 commits intovercel:canaryfrom Jan 14, 2022
Merged
Add onLoad gottcha note to next/script docs#33097kodiakhq[bot] merged 4 commits intovercel:canaryfrom
onLoad gottcha note to next/script docs#33097kodiakhq[bot] merged 4 commits intovercel:canaryfrom
Conversation
Add a note to the onLoad section of the next/script documenation clarifying that onLoad will not run if `strategy="beforeInteractive"`.
leerob
reviewed
Jan 8, 2022
leerob
previously approved these changes
Jan 8, 2022
Contributor
styfle
approved these changes
Jan 14, 2022
next/script docs
next/script docsonLoad gottcha note to next/script docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a note to the onLoad section of the next/script documentation clarifying that onLoad will not run if
strategy="beforeInteractive". (That tripped me up for a bit so I thought I'd update the docs to save any one else the hassle :).)