Move resolve-url-loader into Next.js by timneutkens · Pull Request #32932 · vercel/next.js

timneutkens · 2022-01-01T15:11:37Z

Moves resolve-url-loader into Next.js and strips out all features that are not used like rework support. Will reduce install size as well as allow for optimizing the approach in the near future. Also solves the issue where the postcss plugin it uses causes a warning.

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

Fixes vercel#32157 Moves resolve-url-loader into Next.js and strips out all features that are not used like `rework` support. Will reduce install size as well as allow for optimizing the approach in the near future.

This reverts commit 7c09a07.

ijjk · 2022-01-02T21:54:02Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js fix/issue-32157	Change
buildDuration	13.9s	14.1s	⚠️ +184ms
buildDurationCached	3.1s	3.2s	⚠️ +28ms
nodeModulesSize	348 MB	348 MB	-34.2 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js fix/issue-32157	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.863	2.859	0
/ avg req/sec	873.29	874.51	+1.22
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.277	1.3	⚠️ +0.02
/error-in-render avg req/sec	1957.29	1923.14	⚠️ -34.15

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/issue-32157	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27 kB	27 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	70.9 kB	70.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/issue-32157	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/issue-32157	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	4.74 kB	4.74 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.13 kB	2.13 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/issue-32157	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/issue-32157	Change
index.html gzip	533 B	533 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	528 B	528 B	✓
Overall change	1.61 kB	1.61 kB	✓

Default Build with SWC (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js fix/issue-32157	Change
buildDuration	15.3s	15.2s	-26ms
buildDurationCached	3.2s	3.2s	-8ms
nodeModulesSize	348 MB	348 MB	-34.2 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js fix/issue-32157	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.853	2.854	0
/ avg req/sec	876.31	875.88	⚠️ -0.43
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.299	1.287	-0.01
/error-in-render avg req/sec	1924.46	1943.03	+18.57

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/issue-32157	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	27.2 kB	27.2 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.1 kB	71.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/issue-32157	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/issue-32157	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.36 kB	2.36 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	906 B	906 B	✓
image-HASH.js gzip	4.76 kB	4.76 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.19 kB	2.19 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/issue-32157	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/issue-32157	Change
index.html gzip	532 B	532 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: ec751f4

Move resolve-url-loader into Next.js

bc59da7

Fixes vercel#32157 Moves resolve-url-loader into Next.js and strips out all features that are not used like `rework` support. Will reduce install size as well as allow for optimizing the approach in the near future.

timneutkens requested review from huozhi, ijjk, padmaia and shuding as code owners January 1, 2022 15:11

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 1, 2022

Update precompiled

c0e6fbb

This comment has been minimized.

Sign in to view

Use loader-utils 2

3b6b459

This comment has been minimized.

Sign in to view

timneutkens added 4 commits January 1, 2022 21:36

Update trace test

7c09a07

Revert "Update trace test"

7874109

This reverts commit 7c09a07.

Add es5-ext as it's used in trace tests

a5299d1

Update join-function.js

fd04e13

This comment has been minimized.

Sign in to view

Update bundle5.js

e45a51d

This comment has been minimized.

Sign in to view

ijjk reviewed Jan 2, 2022

View reviewed changes

Comment thread package.json

ijjk approved these changes Jan 2, 2022

View reviewed changes

Merge branch 'canary' into fix/issue-32157

ec751f4

ijjk merged commit 88a5f26 into vercel:canary Jan 2, 2022

vercel locked as resolved and limited conversation to collaborators Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move resolve-url-loader into Next.js#32932

Move resolve-url-loader into Next.js#32932
ijjk merged 9 commits intovercel:canaryfrom
timneutkens:fix/issue-32157

timneutkens commented Jan 1, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

ijjk commented Jan 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

timneutkens commented Jan 1, 2022

Bug

Feature

Documentation / Examples

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

ijjk commented Jan 2, 2022

Stats from current PR

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants