Skip to content

Fix issue with escape-string-regexp in IE11#32708

Merged
ijjk merged 6 commits intovercel:canaryfrom
ijjk:fix/escape-regex-ie11
Jan 3, 2022
Merged

Fix issue with escape-string-regexp in IE11#32708
ijjk merged 6 commits intovercel:canaryfrom
ijjk:fix/escape-regex-ie11

Conversation

@ijjk
Copy link
Copy Markdown
Member

@ijjk ijjk commented Dec 21, 2021

This updates to not leverage escape-string-regexp client-side as the module itself contains an arrow function which is not transpiled currently causing can incompatibility with IE11.

Fixes: #32429

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 21, 2021
@ijjk

This comment has been minimized.

Sign in to view
timneutkens
timneutkens reviewed Dec 22, 2021
View reviewed changes
Comment thread packages/next/shared/lib/router/utils/prepare-destination.ts Outdated
@ijjk ijjk requested a review from padmaia as a code owner December 22, 2021 15:45
@ijjk ijjk requested a review from timneutkens December 22, 2021 15:56
@ijjk
Copy link
Copy Markdown
Member Author

ijjk commented Dec 22, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/escape-regex-ie11 Change
buildDuration 16.7s 17.2s ⚠️ +416ms
buildDurationCached 3.4s 3.4s -42ms
nodeModulesSize 348 MB 348 MB -1.64 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/escape-regex-ie11 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.904 2.909 0
/ avg req/sec 860.91 859.49 ⚠️ -1.42
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.32 1.336 ⚠️ +0.02
/error-in-render avg req/sec 1894.56 1870.73 ⚠️ -23.83
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/escape-regex-ie11 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27 kB 27 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 70.9 kB 70.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/escape-regex-ie11 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/escape-regex-ie11 Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.73 kB 4.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/escape-regex-ie11 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/escape-regex-ie11 Change
index.html gzip 533 B 533 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/escape-regex-ie11 Change
buildDuration 18.4s 18.4s -66ms
buildDurationCached 3.4s 3.3s -21ms
nodeModulesSize 348 MB 348 MB -1.64 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/escape-regex-ie11 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.908 2.867 -0.04
/ avg req/sec 859.79 871.87 +12.08
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.317 1.314 0
/error-in-render avg req/sec 1898.82 1902.9 +4.08
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/escape-regex-ie11 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.1 kB 71.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/escape-regex-ie11 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/escape-regex-ie11 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.75 kB 4.75 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/escape-regex-ie11 Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/escape-regex-ie11 Change
index.html gzip 530 B 530 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 50265ee

@ijjk ijjk requested review from balazsorban44 and styfle January 3, 2022 16:11
styfle
styfle reviewed Jan 3, 2022
View reviewed changes
Comment thread packages/next/shared/lib/escape-regexp.ts
@styfle
Copy link
Copy Markdown
Contributor

styfle commented Jan 3, 2022

We really need a solid deprecation plan for IE 11

styfle
styfle previously approved these changes Jan 3, 2022
View reviewed changes
@ijjk ijjk merged commit 4d30771 into vercel:canary Jan 3, 2022
@ijjk ijjk deleted the fix/escape-regex-ie11 branch January 3, 2022 17:41
tpreusse added a commit to orbiting/republik-frontend that referenced this pull request Jan 11, 2022
@tpreusse
bump to canary for IE 11 fix
9d8b453 
vercel/next.js#32708
@vercel vercel locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@huozhi huozhi Awaiting requested review from huozhi

@shuding shuding Awaiting requested review from shuding

@padmaia padmaia Awaiting requested review from padmaia

@timneutkens timneutkens Awaiting requested review from timneutkens

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

1 more reviewer

@styfle styfle styfle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enabling rewrites causes escape-string-regexp to be bundled which is not IE11 compatible

3 participants

@ijjk @styfle @timneutkens