Skip to content

fix(next/jest): do not watch .next folder#32659

Merged
kodiakhq[bot] merged 1 commit intocanaryfrom
fix/ignore-dot-next-jest
Dec 19, 2021
Merged

fix(next/jest): do not watch .next folder#32659
kodiakhq[bot] merged 1 commit intocanaryfrom
fix/ignore-dot-next-jest

Conversation

@balazsorban44
Copy link
Copy Markdown
Contributor

@balazsorban44 balazsorban44 commented Dec 19, 2021

jest --watch looks for changes in dotfiles and folders by default, which resulted in the tests being re-run when navigating between pages with next dev.

Fixes #32650

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@balazsorban44 balazsorban44 mentioned this pull request Dec 19, 2021
Closed
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Dec 19, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/ignore-dot-next-jest Change
buildDuration 19s 18.9s -30ms
buildDurationCached 3.5s 3.5s ⚠️ +20ms
nodeModulesSize 348 MB 348 MB ⚠️ +387 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix/ignore-dot-next-jest Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.057 3.087 ⚠️ +0.03
/ avg req/sec 817.89 809.82 ⚠️ -8.07
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.405 1.414 ⚠️ +0.01
/error-in-render avg req/sec 1779.35 1768.62 ⚠️ -10.73
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/ignore-dot-next-jest Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 30.2 kB 30.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 74 kB 74 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/ignore-dot-next-jest Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix/ignore-dot-next-jest Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.73 kB 4.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix/ignore-dot-next-jest Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/ignore-dot-next-jest Change
index.html gzip 533 B 533 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/ignore-dot-next-jest Change
buildDuration 20.3s 20.4s ⚠️ +99ms
buildDurationCached 3.5s 3.5s ⚠️ +28ms
nodeModulesSize 348 MB 348 MB ⚠️ +387 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix/ignore-dot-next-jest Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.008 3.013 0
/ avg req/sec 831.01 829.73 ⚠️ -1.28
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.385 1.441 ⚠️ +0.06
/error-in-render avg req/sec 1805.59 1734.32 ⚠️ -71.27
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/ignore-dot-next-jest Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 30.3 kB 30.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 74.3 kB 74.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/ignore-dot-next-jest Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix/ignore-dot-next-jest Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.75 kB 4.75 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix/ignore-dot-next-jest Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/ignore-dot-next-jest Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 7ee36b9

ijjk
ijjk reviewed Dec 19, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ijjk ijjk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other folders we should ignore as well if no dot files/folders are ignored by default?

@kodiakhq kodiakhq Bot merged commit 6ffa2ba into canary Dec 19, 2021
@kodiakhq kodiakhq Bot deleted the fix/ignore-dot-next-jest branch December 19, 2021 19:03
@balazsorban44
Copy link
Copy Markdown
Contributor Author

balazsorban44 commented Dec 19, 2021

Ones that we should ignore by default? Don't think so.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees

No one assigned

Labels

type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Running the dev script concurrently with the Jest test script causes Jest to re-run the tests on page compilation

2 participants

@balazsorban44 @ijjk