Skip to content

Fix writing strings to the writable stream writer#32637

Merged
kodiakhq[bot] merged 1 commit intovercel:canaryfrom
shuding:shu/8e68
Dec 18, 2021
Merged

Fix writing strings to the writable stream writer#32637
kodiakhq[bot] merged 1 commit intovercel:canaryfrom
shuding:shu/8e68

Conversation

@shuding
Copy link
Copy Markdown
Member

@shuding shuding commented Dec 18, 2021 •
edited
Loading

Only chunks are allowed to write to writable. This fixes the following error in the web runtime:

Uncaught (in promise) TypeError: This TransformStream is being used as a byte stream, but received a string on its
writable side. If you wish to write a string, you'll probably want to explicitly UTF-8-encode it with TextEncoder.

It doesn't fail in the Node.js sandbox since we polyfilled this case (which should be reverted back later).

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 18, 2021
@shuding shuding marked this pull request as ready for review December 18, 2021 18:14
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Dec 18, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/8e68 Change
buildDuration 24.1s 24.6s ⚠️ +527ms
buildDurationCached 4.3s 4.4s ⚠️ +85ms
nodeModulesSize 348 MB 348 MB ⚠️ +176 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/8e68 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.948 4.077 ⚠️ +0.13
/ avg req/sec 633.23 613.16 ⚠️ -20.07
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.087 2.104 ⚠️ +0.02
/error-in-render avg req/sec 1198.04 1188.19 ⚠️ -9.85
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/8e68 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 30.2 kB 30.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 74 kB 74 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/8e68 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/8e68 Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.73 kB 4.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/8e68 Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/8e68 Change
index.html gzip 533 B 533 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/8e68 Change
buildDuration 26.2s 26.4s ⚠️ +158ms
buildDurationCached 4.4s 4.5s ⚠️ +125ms
nodeModulesSize 348 MB 348 MB ⚠️ +176 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/8e68 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.967 4.013 ⚠️ +0.05
/ avg req/sec 630.2 622.98 ⚠️ -7.22
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.093 2.187 ⚠️ +0.09
/error-in-render avg req/sec 1194.26 1142.99 ⚠️ -51.27
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/8e68 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 30.3 kB 30.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 74.3 kB 74.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/8e68 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/8e68 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.75 kB 4.75 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/8e68 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/8e68 Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: c5d5bdc

@kodiakhq kodiakhq Bot merged commit 8b12b17 into vercel:canary Dec 18, 2021
@shuding shuding deleted the shu/8e68 branch December 18, 2021 18:41
@agency-digital-marketing

This comment has been minimized.

Sign in to view
@vercel vercel locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@huozhi huozhi huozhi approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shuding @ijjk @agency-digital-marketing @huozhi