Skip to content

chore: remove duplicate example#32391

Merged
kodiakhq[bot] merged 2 commits intocanaryfrom
remove-duplicate-example
Dec 11, 2021
Merged

chore: remove duplicate example#32391
kodiakhq[bot] merged 2 commits intocanaryfrom
remove-duplicate-example

Conversation

@balazsorban44
Copy link
Copy Markdown
Contributor

Removes the with-typescript-eslint-jest example in favour of the more up-to-date with-jest and with-jest-babel examples, that also support TypeScript etc.

Related #23841

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue was opened via the examples template. label Dec 11, 2021
@kodiakhq kodiakhq Bot merged commit ac82da2 into canary Dec 11, 2021
@kodiakhq kodiakhq Bot deleted the remove-duplicate-example branch December 11, 2021 21:08
@devinrhode2
Copy link
Copy Markdown

COULD be nice to leave a README.md in this directory recommending usage of with-jest and with-jest-babel instead. But, then we still have clutter when you ls examples/*

@vercel vercel locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

examples Issue was opened via the examples template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants