Skip to content

Fixes #32338 missing Document components trigger an error for production builds#32345

Merged
ijjk merged 7 commits intovercel:canaryfrom
oriolcp:canary
Dec 13, 2021
Merged

Fixes #32338 missing Document components trigger an error for production builds#32345
ijjk merged 7 commits intovercel:canaryfrom
oriolcp:canary

Conversation

@oriolcp
Copy link
Copy Markdown
Contributor

@oriolcp oriolcp commented Dec 9, 2021 •
edited
Loading

Fixes #32338

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the type: next label Dec 9, 2021
@oriolcp oriolcp changed the title Fixes #32338 Make missing Document components trigger an error for production builds Fixes #32338 Make missing Document components trigger an error for production builds Dec 9, 2021
@oriolcp oriolcp changed the title Fixes #32338 Make missing Document components trigger an error for production builds Fixes #32338 missing Document components trigger an error for production builds Dec 9, 2021
balazsorban44
balazsorban44 previously requested changes Dec 10, 2021
View reviewed changes
Comment thread packages/next/server/render.tsx Outdated
@balazsorban44
Copy link
Copy Markdown
Contributor

balazsorban44 commented Dec 10, 2021

Fixes #32278

@balazsorban44 balazsorban44 linked an issue Dec 10, 2021 that may be closed by this pull request
Unable to build intentional Dirty AMP page #32278
Closed
@ijjk ijjk dismissed balazsorban44’s stale review December 13, 2021 22:02

suggestion applied

@ijjk
Copy link
Copy Markdown
Member

ijjk commented Dec 13, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary oriolcp/next.js canary Change
buildDuration 23.8s 22.3s -1.5s
buildDurationCached 4.1s 4.2s ⚠️ +68ms
nodeModulesSize 350 MB 350 MB ⚠️ +192 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary oriolcp/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.899 3.92 ⚠️ +0.02
/ avg req/sec 641.27 637.75 ⚠️ -3.52
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.95 2.01 ⚠️ +0.06
/error-in-render avg req/sec 1281.86 1244.09 ⚠️ -37.77
Client Bundles (main, webpack, commons)
vercel/next.js canary oriolcp/next.js canary Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 30.2 kB 30.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 74 kB 74 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary oriolcp/next.js canary Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary oriolcp/next.js canary Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.39 kB 2.39 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.73 kB 4.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary oriolcp/next.js canary Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary oriolcp/next.js canary Change
index.html gzip 532 B 532 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary oriolcp/next.js canary Change
buildDuration 23.7s 24.9s ⚠️ +1.2s
buildDurationCached 3.9s 4.2s ⚠️ +345ms
nodeModulesSize 350 MB 350 MB ⚠️ +192 B
Page Load Tests Overall increase ✓
vercel/next.js canary oriolcp/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.649 3.586 -0.06
/ avg req/sec 685.03 697.12 +12.09
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.965 1.861 -0.1
/error-in-render avg req/sec 1272.02 1343.68 +71.66
Client Bundles (main, webpack, commons)
vercel/next.js canary oriolcp/next.js canary Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 30.3 kB 30.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 74.2 kB 74.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary oriolcp/next.js canary Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary oriolcp/next.js canary Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.39 kB 2.39 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.75 kB 4.75 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary oriolcp/next.js canary Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary oriolcp/next.js canary Change
index.html gzip 533 B 533 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: 7e1f3f4

@ijjk ijjk merged commit eba9da0 into vercel:canary Dec 13, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

+1 more reviewer

@devknoll devknoll devknoll approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make missing Document components trigger an error for production builds Unable to build intentional Dirty AMP page

4 participants

@oriolcp @balazsorban44 @ijjk @devknoll