Skip to content

Update only fetch all tags for publish commits#32337

Merged
ijjk merged 10 commits intovercel:canaryfrom
ijjk:update/tag-fetch
Dec 9, 2021
Merged

Update only fetch all tags for publish commits#32337
ijjk merged 10 commits intovercel:canaryfrom
ijjk:update/tag-fetch

Conversation

@ijjk
Copy link
Copy Markdown
Member

@ijjk ijjk commented Dec 9, 2021 •
edited
Loading

Alternative to #30350 this aims to remove the 3 minute git fetch step for each build_test_deploy workflow run as it should only be needed for releases and all release commit messages contain only the version

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Dec 9, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk marked this pull request as ready for review December 9, 2021 21:39
styfle
styfle reviewed Dec 9, 2021
View reviewed changes
Comment thread scripts/fetch-tags.mjs Outdated
styfle
styfle reviewed Dec 9, 2021
View reviewed changes
Comment thread scripts/fetch-tags.mjs Outdated
@ijjk ijjk requested a review from styfle December 9, 2021 21:52
styfle
styfle reviewed Dec 9, 2021
View reviewed changes
Comment thread scripts/fetch-tags.mjs
styfle
styfle reviewed Dec 9, 2021
View reviewed changes
Comment thread scripts/fetch-tags.mjs Outdated
styfle
styfle reviewed Dec 9, 2021
View reviewed changes
Comment thread scripts/fetch-tags.mjs Outdated
@ijjk ijjk requested a review from styfle December 9, 2021 22:02
styfle
styfle reviewed Dec 9, 2021
View reviewed changes
Comment thread scripts/fetch-tags.mjs
.toString()
.trim()

const versionString = commitMsg.split(' ').pop().trim()
Copy link
Copy Markdown
Contributor

@styfle styfle Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like %B will log a multiline body. But this is splitting on space. Should it split on \n instead?

Copy link
Copy Markdown
Contributor

@styfle styfle Dec 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trim on line 12 will take care of the newline so you can remove line 14.

I checked an the commit body looks like this:

v12.0.8-canary.1

Copy link
Copy Markdown
Member Author

@ijjk ijjk Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publish commit message will only have one line so we should be able to split only by space

@ijjk
Copy link
Copy Markdown
Member Author

ijjk commented Dec 9, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/tag-fetch Change
buildDuration 18.1s 18.1s -19ms
buildDurationCached 3.4s 3.3s -90ms
nodeModulesSize 351 MB 351 MB -13 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/tag-fetch Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.939 3.009 ⚠️ +0.07
/ avg req/sec 850.52 830.79 ⚠️ -19.73
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.349 1.4 ⚠️ +0.05
/error-in-render avg req/sec 1852.89 1785.7 ⚠️ -67.19
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/tag-fetch Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28.8 kB 28.8 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.7 kB 72.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/tag-fetch Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/tag-fetch Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.39 kB 2.39 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.73 kB 4.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/tag-fetch Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/tag-fetch Change
index.html gzip 531 B 531 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/tag-fetch Change
buildDuration 19.4s 19.4s ⚠️ +28ms
buildDurationCached 3.4s 3.3s -9ms
nodeModulesSize 351 MB 351 MB -13 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/tag-fetch Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.942 2.95 ⚠️ +0.01
/ avg req/sec 849.79 847.46 ⚠️ -2.33
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.346 1.343 0
/error-in-render avg req/sec 1857.75 1861.98 +4.23
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/tag-fetch Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 29 kB 29 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 73 kB 73 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/tag-fetch Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/tag-fetch Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.39 kB 2.39 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.75 kB 4.75 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/tag-fetch Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/tag-fetch Change
index.html gzip 531 B 531 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 8976ed5

@ijjk ijjk merged commit 93ef28b into vercel:canary Dec 9, 2021
@ijjk ijjk deleted the update/tag-fetch branch December 9, 2021 22:36
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

1 more reviewer

@styfle styfle styfle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ijjk @styfle