Skip to content

Check stack property for page export exceptions#32289

Merged
timneutkens merged 3 commits intovercel:canaryfrom
benmerckx:patch-1
Dec 16, 2021
Merged

Check stack property for page export exceptions#32289
timneutkens merged 3 commits intovercel:canaryfrom
benmerckx:patch-1

Conversation

@benmerckx
Copy link
Copy Markdown
Contributor

@benmerckx benmerckx commented Dec 8, 2021 •
edited
Loading

We've had the misfortune of an error-like object being thrown without a stack property. It passes the isError check but then log has no information:

Error occurred prerendering page "/". Read more: https://nextjs.org/docs/messages/prerender-error
undefined

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@benmerckx
Check stack property for page export exceptions
e2969d3 
We've had the misfortune of an error-like object being thrown without a stack property. It passes the isError check but then log has no information:

````
Error occurred prerendering page "/". Read more: https://nextjs.org/docs/messages/prerender-error
undefined
````
@ijjk ijjk added the type: next label Dec 8, 2021
ijjk
ijjk reviewed Dec 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, can we add a test case for this? This can potentially go in this test suite

ijjk
ijjk approved these changes Dec 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk
Copy link
Copy Markdown
Member

ijjk commented Dec 16, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary benmerckx/next.js patch-1 Change
buildDuration 19.8s 19.8s ⚠️ +59ms
buildDurationCached 3.8s 3.7s -98ms
nodeModulesSize 350 MB 350 MB ⚠️ +34 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary benmerckx/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.24 3.257 ⚠️ +0.02
/ avg req/sec 771.53 767.69 ⚠️ -3.84
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.456 1.51 ⚠️ +0.05
/error-in-render avg req/sec 1716.56 1655.58 ⚠️ -60.98
Client Bundles (main, webpack, commons)
vercel/next.js canary benmerckx/next.js patch-1 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 30.2 kB 30.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 74 kB 74 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary benmerckx/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary benmerckx/next.js patch-1 Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.73 kB 4.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary benmerckx/next.js patch-1 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary benmerckx/next.js patch-1 Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary benmerckx/next.js patch-1 Change
buildDuration 21.3s 21.4s ⚠️ +182ms
buildDurationCached 3.7s 3.7s ⚠️ +14ms
nodeModulesSize 350 MB 350 MB ⚠️ +34 B
Page Load Tests Overall increase ✓
vercel/next.js canary benmerckx/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.303 3.257 -0.05
/ avg req/sec 756.95 767.48 +10.53
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.474 1.478 0
/error-in-render avg req/sec 1696.02 1690.91 ⚠️ -5.11
Client Bundles (main, webpack, commons)
vercel/next.js canary benmerckx/next.js patch-1 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 30.3 kB 30.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 74.3 kB 74.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary benmerckx/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary benmerckx/next.js patch-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.75 kB 4.75 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary benmerckx/next.js patch-1 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary benmerckx/next.js patch-1 Change
index.html gzip 533 B 533 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: 2741d38

@ijjk
Copy link
Copy Markdown
Member

ijjk commented Dec 16, 2021

Failing test suites

Commit: 2741d38

test/integration/ondemand/test/index.test.js

  • On Demand Entries > should navigate to pages with dynamic imports
Expand output

● On Demand Entries › should navigate to pages with dynamic imports

TIMED OUT: /Hello/

/nav/dynamic

  479 |     if (!this.originalContent) {
  480 |       this.originalContent = content
> 481 |     }
      |      ^
  482 |     writeFileSync(this.path, content, 'utf8')
  483 |   }
  484 |

  at Object.check (lib/next-test-utils.js:481:15)
  at Object.<anonymous> (integration/ondemand/test/index.test.js:105:13)

@timneutkens timneutkens merged commit 04fbc66 into vercel:canary Dec 16, 2021
@timneutkens
Copy link
Copy Markdown
Contributor

timneutkens commented Dec 16, 2021

Thanks! 🎉

@benmerckx benmerckx deleted the patch-1 branch December 16, 2021 09:03
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees

No one assigned

Labels

type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benmerckx @ijjk @timneutkens