Ensure test wasm does not fail for docs only change#32259
Merged
ijjk merged 1 commit intovercel:canaryfrom Dec 7, 2021
Merged
Conversation
styfle
approved these changes
Dec 7, 2021
styfle
reviewed
Dec 7, 2021
| path: packages/next-swc/crates/wasm/pkg-nodejs | ||
|
|
||
| - run: ls packages/next-swc/crates/wasm | ||
| if: ${{needs.build.outputs.docsChange != 'docs only change'}} |
Contributor
There was a problem hiding this comment.
Is there anyway we could invert these conditions so they don't need to be repeated for every step of every yaml?
Member
Author
There was a problem hiding this comment.
Currently not that we've found as we need the jobs to show as successful for the branch protection rules/kodiak to work correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/vercel/next.js/runs/4449182326?check_suite_focus=true