Skip to content

Ensure conf type for createServer is not changed#32134

Merged
kodiakhq[bot] merged 1 commit intovercel:canaryfrom
ijjk:update/public-conf-type
Dec 4, 2021
Merged

Ensure conf type for createServer is not changed#32134
kodiakhq[bot] merged 1 commit intovercel:canaryfrom
ijjk:update/public-conf-type

Conversation

@ijjk
Copy link
Copy Markdown
Member

@ijjk ijjk commented Dec 4, 2021 •
edited
Loading

This reverts the type for the conf field in ServerOptions isn't changed to require all NextConfig values as this is a breaking change from what was previously required. We should investigate making sure this field is normalized when it is provided via a user.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #32123
x-ref: #31858

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 4, 2021
@ijjk ijjk marked this pull request as ready for review December 4, 2021 22:22
@ijjk
Copy link
Copy Markdown
Member Author

ijjk commented Dec 4, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/public-conf-type Change
buildDuration 21.1s 21.1s ⚠️ +17ms
buildDurationCached 3.9s 3.9s ⚠️ +11ms
nodeModulesSize 347 MB 347 MB ⚠️ +197 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/public-conf-type Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.423 3.418 0
/ avg req/sec 730.28 731.32 +1.04
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.529 1.588 ⚠️ +0.06
/error-in-render avg req/sec 1634.66 1573.97 ⚠️ -60.69
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/public-conf-type Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28.4 kB 28.4 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.3 kB 72.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/public-conf-type Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/public-conf-type Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 635 B 635 B ✓
image-HASH.js gzip 4.49 kB 4.49 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.87 kB 1.87 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 13.3 kB 13.3 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/public-conf-type Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/public-conf-type Change
index.html gzip 532 B 532 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/public-conf-type Change
buildDuration 22.6s 22.7s ⚠️ +146ms
buildDurationCached 3.9s 3.9s -23ms
nodeModulesSize 347 MB 347 MB ⚠️ +197 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/public-conf-type Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.41 3.413 0
/ avg req/sec 733.14 732.56 ⚠️ -0.58
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.585 1.633 ⚠️ +0.05
/error-in-render avg req/sec 1577.71 1530.99 ⚠️ -46.72
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/public-conf-type Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.6 kB 28.6 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 72.5 kB 72.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/public-conf-type Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/public-conf-type Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 622 B 622 B ✓
image-HASH.js gzip 4.53 kB 4.53 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 1.9 kB 1.9 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 13.3 kB 13.3 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/public-conf-type Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/public-conf-type Change
index.html gzip 531 B 531 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 5e29004

@kodiakhq kodiakhq Bot merged commit 769d680 into vercel:canary Dec 4, 2021
@ijjk ijjk deleted the update/public-conf-type branch December 4, 2021 22:58
@sync-by-unito sync-by-unito Bot mentioned this pull request Dec 6, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens timneutkens approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@shuding shuding Awaiting requested review from shuding

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Breaking API change in types from 12.0.4 to 12.0.5

2 participants

@ijjk @timneutkens