telemetry: collect feature usage for linting during build by kyliau · Pull Request #32022 · vercel/next.js

kyliau · 2021-12-02T01:09:43Z

Currently, we have telemetry to measure how ESLint is invoked,
but we do not have telemetry that tells us how many users have
disabled ESLint during build.

This commit adds a new feature, build lint to track this metric.

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

Currently, we have telemetry to measure how ESLint is invoked, but we do not have telemetry that tells us how many users have disabled ESLint during build. This commit adds a new feature, `build lint` to track this metric.

ijjk · 2021-12-07T00:36:34Z

Failing test suites

Commit: d55a86d

test/integration/app-document-add-hmr/test/index.test.js

_app/_document add HMR > should HMR when _app is added
_app/_document add HMR > should HMR when _document is added

Expand output

● _app/_document add HMR › should HMR when _app is added

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  16 | describe('_app/_document add HMR', () => {
  17 |   beforeAll(async () => {
> 18 |     appPort = await findPort()
     |     ^
  19 |     app = await launchApp(appDir, appPort)
  20 |   })
  21 |   afterAll(() => killApp(app))

  at integration/app-document-add-hmr/test/index.test.js:18:5
  at Object.<anonymous> (integration/app-document-add-hmr/test/index.test.js:17:1)

● _app/_document add HMR › should HMR when _document is added

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  16 | describe('_app/_document add HMR', () => {
  17 |   beforeAll(async () => {
> 18 |     appPort = await findPort()
     |     ^
  19 |     app = await launchApp(appDir, appPort)
  20 |   })
  21 |   afterAll(() => killApp(app))

  at integration/app-document-add-hmr/test/index.test.js:18:5
  at Object.<anonymous> (integration/app-document-add-hmr/test/index.test.js:17:1)

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  398 |   return new Promise((resolve, reject) => {
  399 |     const newArgs = [
> 400 |       ...args,
      |               ^
  401 |       function (err, res) {
  402 |         if (err) return reject(err)
  403 |         resolve(res)

  at Object.killApp (lib/next-test-utils.js:400:32)
  at integration/app-document-add-hmr/test/index.test.js:22:38

ijjk · 2021-12-07T02:20:01Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	kyliau/next.js build-lint	Change
buildDuration	19.1s	18.8s	-338ms
buildDurationCached	3.6s	3.6s	-21ms
nodeModulesSize	347 MB	347 MB	⚠️ +577 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	kyliau/next.js build-lint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.064	3.043	-0.02
/ avg req/sec	815.82	821.53	+5.71
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.445	1.416	-0.03
/error-in-render avg req/sec	1730.7	1765.6	+34.9

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kyliau/next.js build-lint	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28.4 kB	28.4 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.3 kB	72.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kyliau/next.js build-lint	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	kyliau/next.js build-lint	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.49 kB	4.49 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.3 kB	13.3 kB	✓

Client Build Manifests

	vercel/next.js canary	kyliau/next.js build-lint	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	kyliau/next.js build-lint	Change
index.html gzip	531 B	531 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	kyliau/next.js build-lint	Change
buildDuration	20.2s	20.4s	⚠️ +267ms
buildDurationCached	3.6s	3.5s	-103ms
nodeModulesSize	347 MB	347 MB	⚠️ +577 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	kyliau/next.js build-lint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.095	3.098	0
/ avg req/sec	807.65	806.89	⚠️ -0.76
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.467	1.391	-0.08
/error-in-render avg req/sec	1704.5	1796.94	+92.44

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kyliau/next.js build-lint	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.6 kB	28.6 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	72.5 kB	72.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kyliau/next.js build-lint	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	kyliau/next.js build-lint	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	622 B	622 B	✓
image-HASH.js gzip	4.53 kB	4.53 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.9 kB	1.9 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.3 kB	13.3 kB	✓

Client Build Manifests

	vercel/next.js canary	kyliau/next.js build-lint	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	kyliau/next.js build-lint	Change
index.html gzip	530 B	530 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: d97debe

kyliau requested review from huozhi, ijjk, padmaia, shuding and timneutkens as code owners December 2, 2021 01:09

ijjk added created-by: Chrome Aurora type: next labels Dec 2, 2021

This comment has been minimized.

Sign in to view

telemetry: collect feature usage for linting during build

f4d2bce

Currently, we have telemetry to measure how ESLint is invoked, but we do not have telemetry that tells us how many users have disabled ESLint during build. This commit adds a new feature, `build lint` to track this metric.

kyliau force-pushed the build-lint branch from 5e37004 to f4d2bce Compare December 2, 2021 17:47

This comment has been minimized.

Sign in to view

Merge branch 'canary' into build-lint

8618d84

This comment has been minimized.

Sign in to view

Merge branch 'canary' into build-lint

d55a86d

ijjk approved these changes Dec 7, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'canary' into build-lint

d97debe

kodiakhq Bot merged commit 53e52fe into vercel:canary Dec 7, 2021

kyliau deleted the build-lint branch December 7, 2021 18:09

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

telemetry: collect feature usage for linting during build#32022

telemetry: collect feature usage for linting during build#32022
kodiakhq[bot] merged 4 commits intovercel:canaryfrom
kyliau:build-lint

kyliau commented Dec 2, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Dec 7, 2021

Uh oh!

This comment has been minimized.

ijjk commented Dec 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kyliau commented Dec 2, 2021

Bug

Feature

Documentation / Examples

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Dec 7, 2021

Failing test suites

Uh oh!

This comment has been minimized.

ijjk commented Dec 7, 2021

Stats from current PR

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants