Skip to content

next-swc: styled-jsx error checking and reporting updated (invalid-styled-jsx-children.md)#31940

Merged
timneutkens merged 6 commits intovercel:canaryfrom
hanneslund:swc-styled-jsx-errors
Dec 20, 2021
Merged

next-swc: styled-jsx error checking and reporting updated (invalid-styled-jsx-children.md)#31940
timneutkens merged 6 commits intovercel:canaryfrom
hanneslund:swc-styled-jsx-errors

Conversation

@hanneslund
Copy link
Copy Markdown
Contributor

@hanneslund hanneslund commented Nov 29, 2021

One step towards completing #30837.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
kdy1
kdy1 suggested changes Dec 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I find some tiny code style issues.

Comment thread packages/next-swc/crates/core/src/styled_jsx/mod.rs Outdated
Comment thread packages/next-swc/crates/core/src/styled_jsx/mod.rs Outdated
@hanneslund
Copy link
Copy Markdown
Contributor Author

hanneslund commented Dec 16, 2021

Thank you for feedback @kdy1. Fixed!

@ijjk
Copy link
Copy Markdown
Member

ijjk commented Dec 16, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary hanneslund/next.js swc-styled-jsx-errors Change
buildDuration 18.2s 18.4s ⚠️ +138ms
buildDurationCached 3.4s 3.4s ⚠️ +22ms
nodeModulesSize 348 MB 348 MB ⚠️ +6 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary hanneslund/next.js swc-styled-jsx-errors Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.885 2.951 ⚠️ +0.07
/ avg req/sec 866.66 847.1 ⚠️ -19.56
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.322 1.347 ⚠️ +0.02
/error-in-render avg req/sec 1891.14 1855.69 ⚠️ -35.45
Client Bundles (main, webpack, commons)
vercel/next.js canary hanneslund/next.js swc-styled-jsx-errors Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 30.2 kB 30.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 74 kB 74 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary hanneslund/next.js swc-styled-jsx-errors Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary hanneslund/next.js swc-styled-jsx-errors Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.73 kB 4.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary hanneslund/next.js swc-styled-jsx-errors Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary hanneslund/next.js swc-styled-jsx-errors Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary hanneslund/next.js swc-styled-jsx-errors Change
buildDuration 19.8s 19.7s -60ms
buildDurationCached 3.5s 3.4s -63ms
nodeModulesSize 348 MB 348 MB ⚠️ +6 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary hanneslund/next.js swc-styled-jsx-errors Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.951 2.968 ⚠️ +0.02
/ avg req/sec 847.11 842.22 ⚠️ -4.89
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.341 1.355 ⚠️ +0.01
/error-in-render avg req/sec 1864.38 1844.48 ⚠️ -19.9
Client Bundles (main, webpack, commons)
vercel/next.js canary hanneslund/next.js swc-styled-jsx-errors Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 30.3 kB 30.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 74.3 kB 74.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary hanneslund/next.js swc-styled-jsx-errors Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary hanneslund/next.js swc-styled-jsx-errors Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.75 kB 4.75 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary hanneslund/next.js swc-styled-jsx-errors Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary hanneslund/next.js swc-styled-jsx-errors Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: ead8cb1

kdy1
kdy1 approved these changes Dec 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@timneutkens timneutkens merged commit 802f4dc into vercel:canary Dec 20, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@huozhi huozhi Awaiting requested review from huozhi

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

1 more reviewer

@kdy1 kdy1 kdy1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hanneslund @ijjk @kdy1 @timneutkens