SWC: Add error checks and tests to next-dynamic by hanneslund · Pull Request #31683 · vercel/next.js

hanneslund · 2021-11-22T12:20:06Z

fixes #31520

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

ijjk · 2021-11-22T12:40:00Z

Failing test suites

Commit: 63bd6a5

test/development/basic-basepath/next-dynamic.test.ts

basic next/dynamic usage > Dynamic import > Multiple modules > should only include the rendered module script tag
basic next/dynamic usage > Dynamic import > Multiple modules > should only load the rendered module in the browser
basic next/dynamic usage > Dynamic import > Multiple modules > should only render one bundle if component is used multiple times
basic next/dynamic usage > Dynamic import > custom chunkfilename > should render the correct filename
basic next/dynamic usage > Dynamic import > custom chunkfilename > should render the component on client side
basic next/dynamic usage > Dynamic import > custom loading > should render custom loading on the server side when ssr:false and loading is provided
basic next/dynamic usage > Dynamic import > custom loading > should render the component on client side
basic next/dynamic usage > Dynamic import > default behavior > should hydrate nested chunks
basic next/dynamic usage > Dynamic import > default behavior > should render the component Head content
basic next/dynamic usage > Dynamic import > ssr:false option > should render the component on client side
basic next/dynamic usage > Dynamic import > ssr:true option > Should render the component on the server side
basic next/dynamic usage > Dynamic import > ssr:true option > should render the component on client side

Expand output

● basic next/dynamic usage › Dynamic import › default behavior › should hydrate nested chunks

TIMED OUT: /Nested 1/

  479 |     if (!this.originalContent) {
  480 |       this.originalContent = content
> 481 |     }
      |      ^
  482 |     writeFileSync(this.path, content, 'utf8')
  483 |   }
  484 |

  at Object.check (lib/next-test-utils.js:481:15)
  at Object.<anonymous> (development/basic-basepath/next-dynamic.test.ts:63:21)

● basic next/dynamic usage › Dynamic import › default behavior › should render the component Head content

TIMED OUT: /test/

  479 |     if (!this.originalContent) {
  480 |       this.originalContent = content
> 481 |     }
      |      ^
  482 |     writeFileSync(this.path, content, 'utf8')
  483 |   }
  484 |

  at Object.check (lib/next-test-utils.js:481:15)
  at Object.<anonymous> (development/basic-basepath/next-dynamic.test.ts:85:21)

● basic next/dynamic usage › Dynamic import › ssr:false option › should render the component on client side

TIMED OUT: /Hello World 1/

  479 |     if (!this.originalContent) {
  480 |       this.originalContent = content
> 481 |     }
      |      ^
  482 |     writeFileSync(this.path, content, 'utf8')
  483 |   }
  484 |

  at Object.check (lib/next-test-utils.js:481:15)
  at Object.<anonymous> (development/basic-basepath/next-dynamic.test.ts:108:21)

● basic next/dynamic usage › Dynamic import › ssr:true option › Should render the component on the server side

expect(received).toContain(expected) // indexOf

Expected substring: "\"dynamicIds\""
Received string:    "<div id=\"__next\" data-reactroot></div><script src=\"/docs/_next/static/chunks/fallback/react-refresh.js?ts=1637584695592\"></script><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"statusCode\":500}},\"page\":\"/_error\",\"query\":{},\"buildId\":\"development\",\"assetPrefix\":\"/docs\",\"isFallback\":false,\"err\":{\"name\":\"ModuleBuildError\",\"message\":\"Module build failed (from ./node_modules/next/dist/build/webpack/loaders/next-swc-loader.js):\\nError: error: import() has to be inside the dynamic() call.\\nRead more: https://nextjs.org/docs/messages/invalid-dynamic-arguments\\n \\n  |\\n3 | const BrowserLoaded = dynamic(async () =\\u003e () =\\u003e \\u003cdiv\\u003eBrowser hydrated\\u003c/div\\u003e, {\\n  |                       ^^^^^^^\\n\\n\",\"stack\":\"ModuleBuildError: Module build failed (from ./node_modules/next/dist/build/webpack/loaders/next-swc-loader.js):\\nError: error: import() has to be inside the dynamic() call.\\nRead more: https://nextjs.org/docs/messages/invalid-dynamic-arguments\\n \\n  |\\n3 | const BrowserLoaded = dynamic(async () =\\u003e () =\\u003e \\u003cdiv\\u003eBrowser hydrated\\u003c/div\\u003e, {\\n  |                       ^^^^^^^\\n\\n\\n    at processResult (/tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:54687:19)\\n    at /tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:54789:5\\n    at /tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:140645:11\\n    at /tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:140497:18\\n    at context.callback (/tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:140370:13)\\n    at /tmp/next-test-1637584582756-631/node_modules/next/dist/build/webpack/loaders/next-swc-loader.js:61:9\"},\"gip\":true,\"scriptLoader\":[]}</script>"

  118 |         expect($('body').html()).not.toContain('"dynamicIds"')
  119 |         expect($('body').text()).not.toMatch('loading...')
> 120 |       })
      |         ^
  121 |
  122 |       it('should render the component on client side', async () => {
  123 |         let browser

  at Object.<anonymous> (development/basic-basepath/next-dynamic.test.ts:120:42)
      at runMicrotasks (<anonymous>)

● basic next/dynamic usage › Dynamic import › ssr:true option › should render the component on client side

TIMED OUT: /Hello World 1/

  479 |     if (!this.originalContent) {
  480 |       this.originalContent = content
> 481 |     }
      |      ^
  482 |     writeFileSync(this.path, content, 'utf8')
  483 |   }
  484 |

  at Object.check (lib/next-test-utils.js:481:15)
  at Object.<anonymous> (development/basic-basepath/next-dynamic.test.ts:127:21)

● basic next/dynamic usage › Dynamic import › custom chunkfilename › should render the correct filename

expect(received).toMatch(expected)

Expected pattern: /test chunkfilename/
Received string:  "{\"props\":{\"pageProps\":{\"statusCode\":500}},\"page\":\"/_error\",\"query\":{},\"buildId\":\"development\",\"assetPrefix\":\"/docs\",\"isFallback\":false,\"err\":{\"name\":\"ModuleBuildError\",\"message\":\"Module build failed (from ./node_modules/next/dist/build/webpack/loaders/next-swc-loader.js):\\nError: error: import() has to be inside the dynamic() call.\\nRead more: https://nextjs.org/docs/messages/invalid-dynamic-arguments\\n \\n  |\\n3 | const BrowserLoaded = dynamic(async () =\\u003e () =\\u003e \\u003cdiv\\u003eBrowser hydrated\\u003c/div\\u003e, {\\n  |                       ^^^^^^^\\n\\n\",\"stack\":\"ModuleBuildError: Module build failed (from ./node_modules/next/dist/build/webpack/loaders/next-swc-loader.js):\\nError: error: import() has to be inside the dynamic() call.\\nRead more: https://nextjs.org/docs/messages/invalid-dynamic-arguments\\n \\n  |\\n3 | const BrowserLoaded = dynamic(async () =\\u003e () =\\u003e \\u003cdiv\\u003eBrowser hydrated\\u003c/div\\u003e, {\\n  |                       ^^^^^^^\\n\\n\\n    at processResult (/tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:54687:19)\\n    at /tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:54789:5\\n    at /tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:140645:11\\n    at /tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:140497:18\\n    at context.callback (/tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:140370:13)\\n    at /tmp/next-test-1637584582756-631/node_modules/next/dist/build/webpack/loaders/next-swc-loader.js:61:9\"},\"gip\":true,\"scriptLoader\":[]}"

  137 |
  138 |     describe('ssr:true option', () => {
> 139 |       it('Should render the component on the server side', async () => {
      |                                          ^
  140 |         const $ = await get$('/docs/dynamic/ssr-true')
  141 |         expect($('body').html()).toContain('"dynamicIds"')
  142 |         expect($('p').text()).toBe('Hello World 1')

  at Object.<anonymous> (development/basic-basepath/next-dynamic.test.ts:139:42)
      at runMicrotasks (<anonymous>)

● basic next/dynamic usage › Dynamic import › custom chunkfilename › should render the component on client side

TIMED OUT: /test chunkfilename/

  479 |     if (!this.originalContent) {
  480 |       this.originalContent = content
> 481 |     }
      |      ^
  482 |     writeFileSync(this.path, content, 'utf8')
  483 |   }
  484 |

  at Object.check (lib/next-test-utils.js:481:15)
  at Object.<anonymous> (development/basic-basepath/next-dynamic.test.ts:146:21)

● basic next/dynamic usage › Dynamic import › custom loading › should render custom loading on the server side when ssr:false and loading is provided

expect(received).toBe(expected) // Object.is equality

Expected: "LOADING"
Received: ""

  156 |           }
  157 |         }
> 158 |       })
      |         ^
  159 |     })
  160 |
  161 |     describe('custom chunkfilename', () => {

  at Object.<anonymous> (development/basic-basepath/next-dynamic.test.ts:158:39)
      at runMicrotasks (<anonymous>)

● basic next/dynamic usage › Dynamic import › custom loading › should render the component on client side

TIMED OUT: /Hello World 1/

  479 |     if (!this.originalContent) {
  480 |       this.originalContent = content
> 481 |     }
      |      ^
  482 |     writeFileSync(this.path, content, 'utf8')
  483 |   }
  484 |

  at Object.check (lib/next-test-utils.js:481:15)
  at Object.<anonymous> (development/basic-basepath/next-dynamic.test.ts:164:21)

● basic next/dynamic usage › Dynamic import › Multiple modules › should only include the rendered module script tag

expect(received).toMatch(expected)

Expected pattern: /hello1\.js/
Received string:  "<head><style data-next-hide-fouc=\"true\">body{display:none}</style><noscript data-next-hide-fouc=\"true\"><style>body{display:block}</style></noscript><meta charset=\"utf-8\"><meta name=\"viewport\" content=\"width=device-width\"><meta name=\"next-head-count\" content=\"2\"><noscript data-n-css></noscript><script defer nomodule src=\"/docs/_next/static/chunks/polyfills.js?ts=1637584789299\"></script><script src=\"/docs/_next/static/chunks/fallback/webpack.js?ts=1637584789299\" defer></script><script src=\"/docs/_next/static/chunks/fallback/main.js?ts=1637584789299\" defer></script><script src=\"/docs/_next/static/chunks/fallback/pages/_app.js?ts=1637584789299\" defer></script><script src=\"/docs/_next/static/chunks/fallback/pages/_error.js?ts=1637584789299\" defer></script><noscript id=\"__next_css__DO_NOT_USE__\"></noscript></head><body><div id=\"__next\" data-reactroot></div><script src=\"/docs/_next/static/chunks/fallback/react-refresh.js?ts=1637584789299\"></script><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"statusCode\":500}},\"page\":\"/_error\",\"query\":{},\"buildId\":\"development\",\"assetPrefix\":\"/docs\",\"isFallback\":false,\"err\":{\"name\":\"ModuleBuildError\",\"message\":\"Module build failed (from ./node_modules/next/dist/build/webpack/loaders/next-swc-loader.js):\\nError: error: import() has to be inside the dynamic() call.\\nRead more: https://nextjs.org/docs/messages/invalid-dynamic-arguments\\n \\n  |\\n3 | const BrowserLoaded = dynamic(async () =\\u003e () =\\u003e \\u003cdiv\\u003eBrowser hydrated\\u003c/div\\u003e, {\\n  |                       ^^^^^^^\\n\\n\",\"stack\":\"ModuleBuildError: Module build failed (from ./node_modules/next/dist/build/webpack/loaders/next-swc-loader.js):\\nError: error: import() has to be inside the dynamic() call.\\nRead more: https://nextjs.org/docs/messages/invalid-dynamic-arguments\\n \\n  |\\n3 | const BrowserLoaded = dynamic(async () =\\u003e () =\\u003e \\u003cdiv\\u003eBrowser hydrated\\u003c/div\\u003e, {\\n  |                       ^^^^^^^\\n\\n\\n    at processResult (/tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:54687:19)\\n    at /tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:54789:5\\n    at /tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:140645:11\\n    at /tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:140497:18\\n    at context.callback (/tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:140370:13)\\n    at /tmp/next-test-1637584582756-631/node_modules/next/dist/build/webpack/loaders/next-swc-loader.js:61:9\"},\"gip\":true,\"scriptLoader\":[]}</script></body>"

  175 |           )
  176 |         } finally {
> 177 |           if (browser) {
      |                         ^
  178 |             await browser.close()
  179 |           }
  180 |         }

  at Object.<anonymous> (development/basic-basepath/next-dynamic.test.ts:177:30)
      at runMicrotasks (<anonymous>)

● basic next/dynamic usage › Dynamic import › Multiple modules › should only load the rendered module in the browser

expect(received).toMatch(expected)

Expected pattern: /hello1\.js/
Received string:  "<head><meta charset=\"utf-8\"><meta name=\"viewport\" content=\"width=device-width\"><meta name=\"next-head-count\" content=\"2\"><noscript data-n-css=\"\"></noscript><script defer=\"\" nomodule=\"\" src=\"/docs/_next/static/chunks/polyfills.js?ts=1637584789369\"></script><script src=\"/docs/_next/static/chunks/fallback/webpack.js?ts=1637584789369\" defer=\"\"></script><script src=\"/docs/_next/static/chunks/fallback/main.js?ts=1637584789369\" defer=\"\"></script><script src=\"/docs/_next/static/chunks/fallback/pages/_app.js?ts=1637584789369\" defer=\"\"></script><script src=\"/docs/_next/static/chunks/fallback/pages/_error.js?ts=1637584789369\" defer=\"\"></script><noscript id=\"__next_css__DO_NOT_USE__\"></noscript></head><body style=\"overflow: hidden;\"><div id=\"__next\" data-reactroot=\"\"></div><script src=\"/docs/_next/static/chunks/fallback/react-refresh.js?ts=1637584789369\"></script><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"statusCode\":500}},\"page\":\"/_error\",\"query\":{},\"buildId\":\"development\",\"assetPrefix\":\"/docs\",\"isFallback\":false,\"err\":{\"name\":\"ModuleBuildError\",\"message\":\"Module build failed (from ./node_modules/next/dist/build/webpack/loaders/next-swc-loader.js):\\nError: error: import() has to be inside the dynamic() call.\\nRead more: https://nextjs.org/docs/messages/invalid-dynamic-arguments\\n \\n  |\\n3 | const BrowserLoaded = dynamic(async () =\\u003e () =\\u003e \\u003cdiv\\u003eBrowser hydrated\\u003c/div\\u003e, {\\n  |                       ^^^^^^^\\n\\n\",\"stack\":\"ModuleBuildError: Module build failed (from ./node_modules/next/dist/build/webpack/loaders/next-swc-loader.js):\\nError: error: import() has to be inside the dynamic() call.\\nRead more: https://nextjs.org/docs/messages/invalid-dynamic-arguments\\n \\n  |\\n3 | const BrowserLoaded = dynamic(async () =\\u003e () =\\u003e \\u003cdiv\\u003eBrowser hydrated\\u003c/div\\u003e, {\\n  |                       ^^^^^^^\\n\\n\\n    at processResult (/tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:54687:19)\\n    at /tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:54789:5\\n    at /tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:140645:11\\n    at /tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:140497:18\\n    at context.callback (/tmp/next-test-1637584582756-631/node_modules/next/dist/compiled/webpack/bundle5.js:140370:13)\\n    at /tmp/next-test-1637584582756-631/node_modules/next/dist/build/webpack/loaders/next-swc-loader.js:61:9\"},\"gip\":true,\"scriptLoader\":[]}</script><div id=\"__next-build-watcher\" style=\"position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;\"></div><next-route-announcer><p aria-live=\"assertive\" id=\"__next-route-announcer__\" role=\"alert\" style=\"border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; width: 1px; white-space: nowrap; overflow-wrap: normal;\"></p></next-route-announcer><nextjs-portal></nextjs-portal></body>"

  183 |
  184 |     describe('custom loading', () => {
> 185 |       it('should render custom loading on the server side when `ssr:false` and `loading` is provided', async () => {
      |                                  ^
  186 |         const $ = await get$('/docs/dynamic/no-ssr-custom-loading')
  187 |         expect($('p').text()).toBe('LOADING')
  188 |       })

  at Object.<anonymous> (development/basic-basepath/next-dynamic.test.ts:185:34)

● basic next/dynamic usage › Dynamic import › Multiple modules › should only render one bundle if component is used multiple times

TypeError: Cannot read property 'length' of null

  195 |             '/docs/dynamic/no-ssr-custom-loading'
  196 |           )
> 197 |           await check(
      |                       ^
  198 |             () => browser.elementByCss('body').text(),
  199 |             /Hello World 1/
  200 |           )

  at Object.<anonymous> (development/basic-basepath/next-dynamic.test.ts:197:64)
      at runMicrotasks (<anonymous>)

timneutkens

Very nice 💯 Could you send me a message on twitter.com/timneutkens / email at the address shown on https://timn.tech/

ijjk · 2021-11-26T14:08:34Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	hanneslund/next.js next-dynamic-swc-errors	Change
buildDuration	18.6s	18.5s	-111ms
buildDurationCached	3.4s	3.4s	-11ms
nodeModulesSize	346 MB	346 MB	-8 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	hanneslund/next.js next-dynamic-swc-errors	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.008	2.992	-0.02
/ avg req/sec	831.2	835.63	+4.43
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.468	1.422	-0.05
/error-in-render avg req/sec	1703.19	1758.13	+54.94

Client Bundles (main, webpack, commons)

	vercel/next.js canary	hanneslund/next.js next-dynamic-swc-errors	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28.4 kB	28.4 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.2 kB	72.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	hanneslund/next.js next-dynamic-swc-errors	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	hanneslund/next.js next-dynamic-swc-errors	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.45 kB	4.45 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.3 kB	13.3 kB	✓

Client Build Manifests

	vercel/next.js canary	hanneslund/next.js next-dynamic-swc-errors	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	hanneslund/next.js next-dynamic-swc-errors	Change
index.html gzip	532 B	532 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	hanneslund/next.js next-dynamic-swc-errors	Change
buildDuration	20s	20.5s	⚠️ +510ms
buildDurationCached	3.4s	3.4s	⚠️ +10ms
nodeModulesSize	346 MB	346 MB	-8 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	hanneslund/next.js next-dynamic-swc-errors	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.954	2.978	⚠️ +0.02
/ avg req/sec	846.44	839.44	⚠️ -7
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.422	1.375	-0.05
/error-in-render avg req/sec	1758.68	1817.59	+58.91

Client Bundles (main, webpack, commons)

	vercel/next.js canary	hanneslund/next.js next-dynamic-swc-errors	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.6 kB	28.6 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	72.5 kB	72.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	hanneslund/next.js next-dynamic-swc-errors	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	hanneslund/next.js next-dynamic-swc-errors	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	622 B	622 B	✓
image-HASH.js gzip	4.47 kB	4.47 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.91 kB	1.91 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.2 kB	13.2 kB	✓

Client Build Manifests

	vercel/next.js canary	hanneslund/next.js next-dynamic-swc-errors	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	hanneslund/next.js next-dynamic-swc-errors	Change
index.html gzip	532 B	532 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: c70afd1

Add error checks and tests to next-dynamic

63bd6a5

hanneslund requested review from huozhi, ijjk, shuding and timneutkens as code owners November 22, 2021 12:20

ijjk added the area: documentation label Nov 22, 2021

This comment has been minimized.

Sign in to view

Remove emitted error and update docs

6c51635

This comment has been minimized.

Sign in to view

timneutkens approved these changes Nov 26, 2021

View reviewed changes

kodiakhq Bot added 2 commits November 26, 2021 13:46

Merge branch 'canary' into next-dynamic-swc-errors

5c56281

Merge branch 'canary' into next-dynamic-swc-errors

c70afd1

kodiakhq Bot merged commit 466687e into vercel:canary Nov 26, 2021

hanneslund deleted the next-dynamic-swc-errors branch November 28, 2021 20:39

MikeDupree mentioned this pull request Dec 17, 2021

Fixes issue with next/dynamic when running next version > 12.0.3 vercel/commerce#618

Merged

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SWC: Add error checks and tests to next-dynamic#31683

SWC: Add error checks and tests to next-dynamic#31683
kodiakhq[bot] merged 4 commits intovercel:canaryfrom
hanneslund:next-dynamic-swc-errors

hanneslund commented Nov 22, 2021 •

edited

Loading

Uh oh!

ijjk commented Nov 22, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

timneutkens left a comment

Uh oh!

ijjk commented Nov 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

hanneslund commented Nov 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bug

Feature

Documentation / Examples

Uh oh!

ijjk commented Nov 22, 2021

Failing test suites

Uh oh!

This comment has been minimized.

This comment has been minimized.

timneutkens left a comment

Choose a reason for hiding this comment

Uh oh!

ijjk commented Nov 26, 2021

Stats from current PR

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hanneslund commented Nov 22, 2021 •

edited

Loading