Skip to content

avoid mutating response.cookie options#31679

Merged
kodiakhq[bot] merged 1 commit intocanaryfrom
fix-31666-response-cookie
Nov 22, 2021
Merged

avoid mutating response.cookie options#31679
kodiakhq[bot] merged 1 commit intocanaryfrom
fix-31666-response-cookie

Conversation

@dferber90
Copy link
Copy Markdown
Contributor

@dferber90 dferber90 commented Nov 22, 2021 •
edited
Loading

Previously response.cookie(name, value, options) would mutate the passed in options which lead to unexpected behaviour as described in #31666.

This PR clones the options argument before mutating it.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

closes #31666

dferber90
dferber90 commented Nov 22, 2021
View reviewed changes
Comment thread test/unit/web-runtime/next-response.test.ts Outdated
Copy link
Copy Markdown
Contributor Author

@dferber90 dferber90 Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we want to keep this test or not.

@dferber90 dferber90 force-pushed the fix-31666-response-cookie branch from d679f18 to 0e6ed09 Compare November 22, 2021 10:19
shuding
shuding previously approved these changes Nov 22, 2021
View reviewed changes
@dferber90 dferber90 force-pushed the fix-31666-response-cookie branch from 0e6ed09 to d065449 Compare November 22, 2021 10:36
@dferber90 dferber90 requested a review from shuding November 22, 2021 10:37
@dferber90 dferber90 force-pushed the fix-31666-response-cookie branch from d065449 to e33ddbb Compare November 22, 2021 10:41
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Nov 22, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-31666-response-cookie Change
buildDuration 18s 18.4s ⚠️ +378ms
buildDurationCached 3.6s 3.6s ⚠️ +77ms
nodeModulesSize 339 MB 339 MB ⚠️ +127 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-31666-response-cookie Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.97 2.962 -0.01
/ avg req/sec 841.74 844.06 +2.32
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.417 1.396 -0.02
/error-in-render avg req/sec 1764.03 1790.51 +26.48
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix-31666-response-cookie Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28.4 kB 28.4 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.2 kB 72.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-31666-response-cookie Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix-31666-response-cookie Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 635 B 635 B ✓
image-HASH.js gzip 4.45 kB 4.45 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.87 kB 1.87 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 13.3 kB 13.3 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix-31666-response-cookie Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-31666-response-cookie Change
index.html gzip 532 B 532 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-31666-response-cookie Change
buildDuration 19.9s 19.9s ⚠️ +1ms
buildDurationCached 3.6s 3.6s -85ms
nodeModulesSize 339 MB 339 MB ⚠️ +127 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-31666-response-cookie Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.961 3.005 ⚠️ +0.04
/ avg req/sec 844.21 831.81 ⚠️ -12.4
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.443 1.394 -0.05
/error-in-render avg req/sec 1732.93 1793.27 +60.34
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix-31666-response-cookie Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.6 kB 28.6 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 72.5 kB 72.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-31666-response-cookie Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix-31666-response-cookie Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 622 B 622 B ✓
image-HASH.js gzip 4.47 kB 4.47 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 1.91 kB 1.91 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 13.2 kB 13.2 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix-31666-response-cookie Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-31666-response-cookie Change
index.html gzip 533 B 533 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: e33ddbb

@kodiakhq kodiakhq Bot merged commit feabd54 into canary Nov 22, 2021
@kodiakhq kodiakhq Bot deleted the fix-31666-response-cookie branch November 22, 2021 11:20
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shuding shuding shuding approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@ijjk ijjk Awaiting requested review from ijjk

@timneutkens timneutkens Awaiting requested review from timneutkens

@javivelasco javivelasco Awaiting requested review from javivelasco

Assignees

No one assigned

Labels

type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Middleware: response.cookie mutates options argument

3 participants

@dferber90 @ijjk @shuding