Skip to content

Update next export documentation.#31465

Merged
leerob merged 7 commits intocanaryfrom
leerob-patch-1
Nov 30, 2021
Merged

Update next export documentation.#31465
leerob merged 7 commits intocanaryfrom
leerob-patch-1

Conversation

@leerob
Copy link
Copy Markdown
Contributor

@leerob leerob commented Nov 15, 2021

This more clearly lists what features are supported and not supported by next export.

Comment thread docs/advanced-features/static-html-export.md Outdated
Comment thread docs/advanced-features/static-html-export.md Outdated
Comment thread docs/advanced-features/static-html-export.md Outdated
Comment thread docs/advanced-features/static-html-export.md Outdated
Comment thread docs/advanced-features/static-html-export.md Outdated
Comment thread docs/advanced-features/static-html-export.md Outdated
Comment thread docs/advanced-features/static-html-export.md Outdated
Co-authored-by: Rich Haines <hello@richardhaines.dev>
Co-authored-by: Matthew Sweeney <mail@mcs.dev>
Comment thread docs/advanced-features/static-html-export.md Outdated
Comment thread docs/advanced-features/static-html-export.md Outdated
Comment thread docs/advanced-features/static-html-export.md Outdated
@leerob
Copy link
Copy Markdown
Contributor Author

leerob commented Nov 28, 2021

Sorry for the slow update, this is now ready for review again 😄

@molebox molebox self-requested a review November 29, 2021 08:45
@molebox
Copy link
Copy Markdown
Contributor

molebox commented Nov 29, 2021

@leerob @MaedahBatool looks like we have soem cross over with 2 PRs here: #31906

molebox
molebox previously approved these changes Nov 29, 2021
Copy link
Copy Markdown
Contributor

@molebox molebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment regarding a more descriptive heading. Other than that LGTM. There is another PR open that is also working on this section: #31906. Might be good to reach out to @MaedahBatool

Comment thread docs/advanced-features/static-html-export.md Outdated
Comment thread docs/advanced-features/static-html-export.md Outdated
@leerob
Copy link
Copy Markdown
Contributor Author

leerob commented Nov 30, 2021

@molebox Fixed! Ready to ship 😄

@leerob leerob merged commit 6e6bd21 into canary Nov 30, 2021
@leerob leerob deleted the leerob-patch-1 branch November 30, 2021 02:50
kodiakhq Bot pushed a commit that referenced this pull request Jan 5, 2022
Building off #31465 for `next export` docs.

- Clearly explains the standard output from `next build`
- Move Dockerfile snippet to example, instead of embedded directly
- Clarify both Vercel and `next start` use the Build API output spec
- Less emphasis on recommending Vercel (more neutrality)
- Mention Middleware & Edge Functions when discussing Vercel
- Add "Going to Production" link at the bottom for related reading
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

created-by: Next.js team PRs by the Next.js team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants