Skip to content

Update swc#30859

Merged
timneutkens merged 1 commit intovercel:canaryfrom
kdy1:swc-ver-20
Nov 3, 2021
Merged

Update swc#30859
timneutkens merged 1 commit intovercel:canaryfrom
kdy1:swc-ver-20

Conversation

@kdy1
Copy link
Copy Markdown
Contributor

@kdy1 kdy1 commented Nov 3, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

This patch applies

This changes order of destructurin and regenerator. As regenerator pass does not know how to handle destructuring patterns, this change is required to support using pattern bindings in catch clauses.

Fixes #30683.

This fixes detection of this usage, which is used while transpiling arrow expressions.

Fixes #30592.

@ijjk
Copy link
Copy Markdown
Member

ijjk commented Nov 3, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-ver-20 Change
buildDuration 18.1s 18.4s ⚠️ +301ms
buildDurationCached 3.8s 3.7s -140ms
nodeModulesSize 293 MB 293 MB -7 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-ver-20 Change
/ failed reqs 0 0
/ total time (seconds) 2.792 2.966 ⚠️ +0.17
/ avg req/sec 895.37 843.02 ⚠️ -52.35
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.355 1.559 ⚠️ +0.2
/error-in-render avg req/sec 1844.8 1603.9 ⚠️ -240.9
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-ver-20 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-ver-20 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-ver-20 Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-ver-20 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-ver-20 Change
index.html gzip 522 B 522 B
link.html gzip 534 B 534 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-ver-20 Change
buildDuration 18.8s 18.7s -71ms
buildDurationCached 3.8s 3.8s -91ms
nodeModulesSize 293 MB 293 MB -7 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-ver-20 Change
/ failed reqs 0 0
/ total time (seconds) 2.873 2.735 -0.14
/ avg req/sec 870.23 914.05 +43.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.433 1.286 -0.15
/error-in-render avg req/sec 1745.06 1943.86 +198.8
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-ver-20 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-ver-20 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-ver-20 Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-ver-20 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-ver-20 Change
index.html gzip 521 B 521 B
link.html gzip 535 B 535 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB
Commit: b961456

@timneutkens timneutkens merged commit 2004d49 into vercel:canary Nov 3, 2021
@timneutkens timneutkens deleted the swc-ver-20 branch November 3, 2021 08:31
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@kdy1 kdy1 self-assigned this Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ambiguous Error During compile whole app This is undefined in object getter

3 participants