Keep attempting to load binary files after failure#30755
Merged
kodiakhq[bot] merged 2 commits intovercel:canaryfrom Nov 1, 2021
Merged
Keep attempting to load binary files after failure#30755kodiakhq[bot] merged 2 commits intovercel:canaryfrom
kodiakhq[bot] merged 2 commits intovercel:canaryfrom
Conversation
Multiple binaries may be installed when only one of them will work with the host machine (limitation of `optionalDependencies`). Failing to `require` a binary that exists does not necessarily mean there is a problem with the binary.
Contributor
|
Will this close #30740 ? |
10 tasks
styfle
approved these changes
Nov 1, 2021
Member
Author
|
@styfle Yeah I just closed with a comment |
ijjk
approved these changes
Nov 1, 2021
This comment has been minimized.
This comment has been minimized.
Member
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | padmaia/next.js fix/load-musl-binding | Change | |
|---|---|---|---|
| buildDuration | 17.6s | 17.8s | |
| buildDurationCached | 3.6s | 3.7s | |
| nodeModulesSize | 293 MB | 293 MB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | padmaia/next.js fix/load-musl-binding | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.909 | 2.856 | -0.05 |
| / avg req/sec | 859.34 | 875.37 | +16.03 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.366 | 1.323 | -0.04 |
| /error-in-render avg req/sec | 1829.85 | 1890.07 | +60.22 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | padmaia/next.js fix/load-musl-binding | Change | |
|---|---|---|---|
| 450.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
| main-HASH.js gzip | 28 kB | 28 kB | ✓ |
| webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
| Overall change | 71.9 kB | 71.9 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | padmaia/next.js fix/load-musl-binding | Change | |
|---|---|---|---|
| polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | padmaia/next.js fix/load-musl-binding | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.23 kB | 1.23 kB | ✓ |
| _error-HASH.js gzip | 194 B | 194 B | ✓ |
| amp-HASH.js gzip | 312 B | 312 B | ✓ |
| css-HASH.js gzip | 327 B | 327 B | ✓ |
| dynamic-HASH.js gzip | 2.38 kB | 2.38 kB | ✓ |
| head-HASH.js gzip | 350 B | 350 B | ✓ |
| hooks-HASH.js gzip | 635 B | 635 B | ✓ |
| image-HASH.js gzip | 4.44 kB | 4.44 kB | ✓ |
| index-HASH.js gzip | 263 B | 263 B | ✓ |
| link-HASH.js gzip | 1.87 kB | 1.87 kB | ✓ |
| routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
| script-HASH.js gzip | 383 B | 383 B | ✓ |
| withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
| 334f979574ae..6f4.css gzip | 106 B | 106 B | ✓ |
| Overall change | 13.1 kB | 13.1 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | padmaia/next.js fix/load-musl-binding | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 459 B | 459 B | ✓ |
| Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | padmaia/next.js fix/load-musl-binding | Change | |
|---|---|---|---|
| index.html gzip | 534 B | 534 B | ✓ |
| link.html gzip | 547 B | 547 B | ✓ |
| withRouter.html gzip | 527 B | 527 B | ✓ |
| Overall change | 1.61 kB | 1.61 kB | ✓ |
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
| vercel/next.js canary | padmaia/next.js fix/load-musl-binding | Change | |
|---|---|---|---|
| buildDuration | 17.9s | 18.7s | |
| buildDurationCached | 3.6s | 3.6s | -5ms |
| nodeModulesSize | 293 MB | 293 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | padmaia/next.js fix/load-musl-binding | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.797 | 2.775 | -0.02 |
| / avg req/sec | 893.86 | 900.94 | +7.08 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.264 | 1.281 | |
| /error-in-render avg req/sec | 1978.38 | 1951.8 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | padmaia/next.js fix/load-musl-binding | Change | |
|---|---|---|---|
| 450.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
| main-HASH.js gzip | 28.2 kB | 28.2 kB | ✓ |
| webpack-HASH.js gzip | 1.43 kB | 1.43 kB | ✓ |
| Overall change | 72.1 kB | 72.1 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | padmaia/next.js fix/load-musl-binding | Change | |
|---|---|---|---|
| polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | padmaia/next.js fix/load-musl-binding | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.22 kB | 1.22 kB | ✓ |
| _error-HASH.js gzip | 180 B | 180 B | ✓ |
| amp-HASH.js gzip | 305 B | 305 B | ✓ |
| css-HASH.js gzip | 321 B | 321 B | ✓ |
| dynamic-HASH.js gzip | 2.38 kB | 2.38 kB | ✓ |
| head-HASH.js gzip | 342 B | 342 B | ✓ |
| hooks-HASH.js gzip | 622 B | 622 B | ✓ |
| image-HASH.js gzip | 4.46 kB | 4.46 kB | ✓ |
| index-HASH.js gzip | 256 B | 256 B | ✓ |
| link-HASH.js gzip | 1.91 kB | 1.91 kB | ✓ |
| routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
| script-HASH.js gzip | 375 B | 375 B | ✓ |
| withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
| 334f979574ae..6f4.css gzip | 106 B | 106 B | ✓ |
| Overall change | 13.1 kB | 13.1 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | padmaia/next.js fix/load-musl-binding | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 460 B | 460 B | ✓ |
| Overall change | 460 B | 460 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | padmaia/next.js fix/load-musl-binding | Change | |
|---|---|---|---|
| index.html gzip | 535 B | 535 B | ✓ |
| link.html gzip | 548 B | 548 B | ✓ |
| withRouter.html gzip | 529 B | 529 B | ✓ |
| Overall change | 1.61 kB | 1.61 kB | ✓ |
timneutkens
pushed a commit
to timneutkens/next.js
that referenced
this pull request
Nov 2, 2021
Multiple binaries may be installed when only one of them will work with the host machine (limitation of `optionalDependencies`). Failing to `require` a binary that exists does not necessarily mean there is a problem with the binary. We need to keep checking if other binaries work. Fixes vercel#30713 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple binaries may be installed when only one of them will work with
the host machine (limitation of
optionalDependencies). Failing torequirea binary that exists does not necessarily mean there is aproblem with the binary. We need to keep checking if other binaries work.
Fixes #30713
Bug
fixes #numbercontributing.mdFeature
fixes #numbercontributing.mdDocumentation / Examples
yarn lint