Remove isCommonJS check as it has been moved to next-swc by timneutkens · Pull Request #30677 · vercel/next.js

timneutkens · 2021-10-30T21:20:09Z

Follow-up to #30661

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

ijjk · 2021-10-30T21:50:29Z

Failing test suites

Commit: 8d202a5

test/development/basic-basepath/hmr.test.ts

basic HMR > Hot Module Reloading > editing a page > should update styles correctly

Expand output

● basic HMR › Hot Module Reloading › editing a page › should update styles correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for selector ".hmr-style-page p"
============================================================

  250 |     return this.chain(() => {
  251 |       return page
> 252 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  253 |         .then(async (el) => {
  254 |           // it seems selenium waits longer and tests rely on this behavior
  255 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:252:10

ijjk · 2021-10-30T21:56:55Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js add/remove-commonjs-check-in-loader	Change
buildDuration	25.6s	25.1s	-534ms
buildDurationCached	5.2s	5.2s	-33ms
nodeModulesSize	294 MB	294 MB	-589 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-commonjs-check-in-loader	Change
/ failed reqs	0	0	✓
/ total time (seconds)	4.039	4.09	⚠️ +0.05
/ avg req/sec	618.94	611.18	⚠️ -7.76
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.104	2.105	0
/error-in-render avg req/sec	1188.26	1187.51	⚠️ -0.75

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/remove-commonjs-check-in-loader	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28 kB	28 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	71.9 kB	71.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-commonjs-check-in-loader	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/remove-commonjs-check-in-loader	Change
_app-HASH.js gzip	1.23 kB	1.23 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.44 kB	4.44 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
334f979574ae..6f4.css gzip	106 B	106 B	✓
Overall change	13.1 kB	13.1 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-commonjs-check-in-loader	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/remove-commonjs-check-in-loader	Change
index.html gzip	533 B	533 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.61 kB	1.61 kB	✓

Default Build with SWC (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js add/remove-commonjs-check-in-loader	Change
buildDuration	26.8s	27.5s	⚠️ +618ms
buildDurationCached	5.2s	5.3s	⚠️ +114ms
nodeModulesSize	294 MB	294 MB	-589 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-commonjs-check-in-loader	Change
/ failed reqs	0	0	✓
/ total time (seconds)	4.04	4.108	⚠️ +0.07
/ avg req/sec	618.77	608.62	⚠️ -10.15
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.101	2.14	⚠️ +0.04
/error-in-render avg req/sec	1189.73	1168.38	⚠️ -21.35

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/remove-commonjs-check-in-loader	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.2 kB	28.2 kB	✓
webpack-HASH.js gzip	1.43 kB	1.43 kB	✓
Overall change	72.1 kB	72.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-commonjs-check-in-loader	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/remove-commonjs-check-in-loader	Change
_app-HASH.js gzip	1.22 kB	1.22 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	622 B	622 B	✓
image-HASH.js gzip	4.46 kB	4.46 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.91 kB	1.91 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
334f979574ae..6f4.css gzip	106 B	106 B	✓
Overall change	13.1 kB	13.1 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-commonjs-check-in-loader	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/remove-commonjs-check-in-loader	Change
index.html gzip	534 B	534 B	✓
link.html gzip	547 B	547 B	✓
withRouter.html gzip	528 B	528 B	✓
Overall change	1.61 kB	1.61 kB	✓

Commit: 8d202a5

Remove isCommonJS check as it has been moved to next-swc

34f05dc

timneutkens requested review from huozhi, ijjk, padmaia, shuding and styfle as code owners October 30, 2021 21:20

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 30, 2021

ijjk approved these changes Oct 30, 2021

View reviewed changes

ijjk and others added 2 commits October 30, 2021 16:21

Merge branch 'canary' into add/remove-commonjs-check-in-loader

e3b27ee

Merge branch 'canary' into add/remove-commonjs-check-in-loader

8d202a5

ijjk merged commit 8a6307f into vercel:canary Oct 30, 2021

timneutkens deleted the add/remove-commonjs-check-in-loader branch October 31, 2021 06:32

snyk-bot mentioned this pull request Nov 8, 2021

[Snyk] Security upgrade next from 11.1.0 to 12.0.2 MaxMood96/next.js#200

Open

snyk-bot mentioned this pull request Jan 21, 2022

[Snyk] Security upgrade next from 11.1.3 to 12.0.2 MaxMood96/next.js#223

Open

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove isCommonJS check as it has been moved to next-swc#30677

Remove isCommonJS check as it has been moved to next-swc#30677
ijjk merged 3 commits intovercel:canaryfrom
timneutkens:add/remove-commonjs-check-in-loader

timneutkens commented Oct 30, 2021

Uh oh!

ijjk commented Oct 30, 2021

Uh oh!

ijjk commented Oct 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

timneutkens commented Oct 30, 2021

Bug

Feature

Documentation / Examples

Uh oh!

ijjk commented Oct 30, 2021

Failing test suites

Uh oh!

ijjk commented Oct 30, 2021

Stats from current PR

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants