remove Object.fromEntries polyfill for node 10 in test utils by stefanprobst · Pull Request #30657 · vercel/next.js

stefanprobst · 2021-10-30T09:34:41Z

cleanup: this removes the Object.fromEntries poyfill in test utils, which should no longer be required in node 12+.

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

timneutkens

Thanks!

ijjk · 2021-10-30T09:57:10Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	stefanprobst/next.js chore/remove-fromentries-polyfill	Change
buildDuration	22.8s	23s	⚠️ +222ms
buildDurationCached	4.9s	4.7s	-165ms
nodeModulesSize	294 MB	294 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	stefanprobst/next.js chore/remove-fromentries-polyfill	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.704	3.637	-0.07
/ avg req/sec	675	687.31	+12.31
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.089	2.06	-0.03
/error-in-render avg req/sec	1196.89	1213.53	+16.64

Client Bundles (main, webpack, commons)

	vercel/next.js canary	stefanprobst/next.js chore/remove-fromentries-polyfill	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28 kB	28 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	71.9 kB	71.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	stefanprobst/next.js chore/remove-fromentries-polyfill	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	stefanprobst/next.js chore/remove-fromentries-polyfill	Change
_app-HASH.js gzip	1.23 kB	1.23 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.44 kB	4.44 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
334f979574ae..6f4.css gzip	106 B	106 B	✓
Overall change	13.1 kB	13.1 kB	✓

Client Build Manifests

	vercel/next.js canary	stefanprobst/next.js chore/remove-fromentries-polyfill	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	stefanprobst/next.js chore/remove-fromentries-polyfill	Change
index.html gzip	534 B	534 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	528 B	528 B	✓
Overall change	1.61 kB	1.61 kB	✓

Default Build with SWC (Increase detected ⚠️)

General

	vercel/next.js canary	stefanprobst/next.js chore/remove-fromentries-polyfill	Change
buildDuration	25s	24.9s	-162ms
buildDurationCached	4.9s	5s	⚠️ +127ms
nodeModulesSize	294 MB	294 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	stefanprobst/next.js chore/remove-fromentries-polyfill	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.716	3.852	⚠️ +0.14
/ avg req/sec	672.82	649.06	⚠️ -23.76
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.144	2.032	-0.11
/error-in-render avg req/sec	1166.12	1230.03	+63.91

Client Bundles (main, webpack, commons)

	vercel/next.js canary	stefanprobst/next.js chore/remove-fromentries-polyfill	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.2 kB	28.2 kB	✓
webpack-HASH.js gzip	1.43 kB	1.43 kB	✓
Overall change	72.1 kB	72.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	stefanprobst/next.js chore/remove-fromentries-polyfill	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	stefanprobst/next.js chore/remove-fromentries-polyfill	Change
_app-HASH.js gzip	1.22 kB	1.22 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	622 B	622 B	✓
image-HASH.js gzip	4.46 kB	4.46 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.91 kB	1.91 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
334f979574ae..6f4.css gzip	106 B	106 B	✓
Overall change	13.1 kB	13.1 kB	✓

Client Build Manifests

	vercel/next.js canary	stefanprobst/next.js chore/remove-fromentries-polyfill	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	stefanprobst/next.js chore/remove-fromentries-polyfill	Change
index.html gzip	535 B	535 B	✓
link.html gzip	548 B	548 B	✓
withRouter.html gzip	529 B	529 B	✓
Overall change	1.61 kB	1.61 kB	✓

Commit: bae2bec

ijjk · 2021-10-30T10:07:28Z

Failing test suites

Commit: bae2bec

test/integration/preload-viewport/test/index.test.js

Prefetching Links in viewport > should not prefetch already loaded scripts

Expand output

● Prefetching Links in viewport › should not prefetch already loaded scripts

expect(received).toBe(expected) // Object.is equality

Expected: false
Received: true

  397 |     expect(hrefs).toEqual([...new Set(hrefs)])
  398 |
> 399 |     // Verify encoding
      |     ^
  400 |     expect(hrefs.some((e) => e.includes(`%5Bhello%5D-`))).toBe(true)
  401 |   })
  402 |

  at Object.<anonymous> (integration/preload-viewport/test/index.test.js:399:5)

remove Object.fromEntries polyfill for node 10 in test utils

abf6eaa

stefanprobst requested review from huozhi, ijjk, padmaia, shuding, styfle and timneutkens as code owners October 30, 2021 09:34

timneutkens approved these changes Oct 30, 2021

View reviewed changes

Merge branch 'canary' into chore/remove-fromentries-polyfill

bae2bec

timneutkens merged commit 77e1565 into vercel:canary Oct 30, 2021

stefanprobst deleted the chore/remove-fromentries-polyfill branch October 30, 2021 11:15

snyk-bot mentioned this pull request Nov 8, 2021

[Snyk] Security upgrade next from 11.1.0 to 12.0.2 MaxMood96/next.js#200

Open

snyk-bot mentioned this pull request Jan 21, 2022

[Snyk] Security upgrade next from 11.1.3 to 12.0.2 MaxMood96/next.js#223

Open

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove Object.fromEntries polyfill for node 10 in test utils#30657

remove Object.fromEntries polyfill for node 10 in test utils#30657
timneutkens merged 2 commits intovercel:canaryfrom
stefanprobst:chore/remove-fromentries-polyfill

stefanprobst commented Oct 30, 2021

Uh oh!

timneutkens left a comment

Uh oh!

ijjk commented Oct 30, 2021

Uh oh!

ijjk commented Oct 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

stefanprobst commented Oct 30, 2021

Bug

Feature

Documentation / Examples

Uh oh!

timneutkens left a comment

Choose a reason for hiding this comment

Uh oh!

ijjk commented Oct 30, 2021

Stats from current PR

Uh oh!

ijjk commented Oct 30, 2021

Failing test suites

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants