Skip to content

Ensure native binary is available for release stats#30649

Merged
timneutkens merged 2 commits intovercel:canaryfrom
ijjk:fix/release-stats
Oct 30, 2021
Merged

Ensure native binary is available for release stats#30649
timneutkens merged 2 commits intovercel:canaryfrom
ijjk:fix/release-stats

Conversation

@ijjk
Copy link
Copy Markdown
Member

@ijjk ijjk commented Oct 30, 2021

Fixes: https://github.com/vercel/next.js/runs/4053638049?check_suite_focus=true

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Oct 30, 2021
@ijjk ijjk marked this pull request as ready for review October 30, 2021 06:24
@ijjk
Copy link
Copy Markdown
Member Author

ijjk commented Oct 30, 2021

Failing test suites

Commit: 60b157e

test/development/basic-basepath/hmr.test.ts

  • basic HMR > Hot Module Reloading > editing a page > should update styles correctly
Expand output

● basic HMR › Hot Module Reloading › editing a page › should update styles correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for selector ".hmr-style-page p"
============================================================

  250 |     return this.chain(() => {
  251 |       return page
> 252 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  253 |         .then(async (el) => {
  254 |           // it seems selenium waits longer and tests rely on this behavior
  255 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:252:10

@ijjk
Copy link
Copy Markdown
Member Author

ijjk commented Oct 30, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js fix/release-stats Change
buildDuration 23.3s 23.5s ⚠️ +141ms
buildDurationCached 5.2s 4.9s -348ms
nodeModulesSize 294 MB 294 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/release-stats Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.869 3.829 -0.04
/ avg req/sec 646.12 652.9 +6.78
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.981 1.977 0
/error-in-render avg req/sec 1261.82 1264.25 +2.43
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/release-stats Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28 kB 28 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 71.9 kB 71.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/release-stats Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/release-stats Change
_app-HASH.js gzip 1.23 kB 1.23 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 635 B 635 B ✓
image-HASH.js gzip 4.44 kB 4.44 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.87 kB 1.87 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
334f979574ae..6f4.css gzip 106 B 106 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/release-stats Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/release-stats Change
index.html gzip 534 B 534 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js fix/release-stats Change
buildDuration 25.4s 25.4s -50ms
buildDurationCached 5s 5s ⚠️ +11ms
nodeModulesSize 294 MB 294 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/release-stats Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.897 3.826 -0.07
/ avg req/sec 641.52 653.47 +11.95
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.996 1.987 -0.01
/error-in-render avg req/sec 1252.27 1257.93 +5.66
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/release-stats Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.2 kB 28.2 kB ✓
webpack-HASH.js gzip 1.43 kB 1.43 kB ✓
Overall change 72.1 kB 72.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/release-stats Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/release-stats Change
_app-HASH.js gzip 1.22 kB 1.22 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 622 B 622 B ✓
image-HASH.js gzip 4.46 kB 4.46 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 1.91 kB 1.91 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
334f979574ae..6f4.css gzip 106 B 106 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/release-stats Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/release-stats Change
index.html gzip 535 B 535 B ✓
link.html gzip 548 B 548 B ✓
withRouter.html gzip 529 B 529 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: 60b157e

@timneutkens timneutkens merged commit d7d1a05 into vercel:canary Oct 30, 2021
This was referenced Oct 31, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 1, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 8, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jan 21, 2022
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@ijjk ijjk deleted the fix/release-stats branch August 22, 2023 00:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens timneutkens approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ijjk @timneutkens @styfle