Skip to content

Update output tracing to do separate passes#30637

Merged
ijjk merged 2 commits intovercel:canaryfrom
ijjk:update/output-traces
Oct 29, 2021
Merged

Update output tracing to do separate passes#30637
ijjk merged 2 commits intovercel:canaryfrom
ijjk:update/output-traces

Conversation

@ijjk
Copy link
Copy Markdown
Member

@ijjk ijjk commented Oct 29, 2021 •
edited
Loading

This separates the tracing out into two passes, the first only traces transpiled sources to gather fs/path usage and the then the second traces node_modules specifically running against the generated webpack outputs which ensures we are matching the expected ESM/CJS files.

Fixes: #30561
x-ref: #30484
x-ref: #30572

Test deployment with this change done here: https://cofe-q7cnwlpks-ijjk-testing.vercel.app/

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 29, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk marked this pull request as ready for review October 29, 2021 21:45
@ijjk
Copy link
Copy Markdown
Member Author

ijjk commented Oct 29, 2021

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/output-traces Change
buildDuration 23.3s 24.4s ⚠️ +1.1s
buildDurationCached 4.5s 5s ⚠️ +508ms
nodeModulesSize 294 MB 294 MB ⚠️ +4.46 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/output-traces Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.117 3.97 -0.15
/ avg req/sec 607.27 629.71 +22.44
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.221 2.264 ⚠️ +0.04
/error-in-render avg req/sec 1125.41 1104.05 ⚠️ -21.36
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/output-traces Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28 kB 28 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 71.9 kB 71.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/output-traces Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/output-traces Change
_app-HASH.js gzip 1.23 kB 1.23 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 635 B 635 B ✓
image-HASH.js gzip 4.44 kB 4.44 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.87 kB 1.87 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
334f979574ae..6f4.css gzip 106 B 106 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/output-traces Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/output-traces Change
index.html gzip 534 B 534 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/output-traces Change
buildDuration 26.1s 26s -127ms
buildDurationCached 4.6s 5.1s ⚠️ +465ms
nodeModulesSize 294 MB 294 MB ⚠️ +4.46 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/output-traces Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.953 3.839 -0.11
/ avg req/sec 632.5 651.17 +18.67
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.161 2.125 -0.04
/error-in-render avg req/sec 1157.03 1176.72 +19.69
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/output-traces Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.2 kB 28.2 kB ✓
webpack-HASH.js gzip 1.43 kB 1.43 kB ✓
Overall change 72.1 kB 72.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/output-traces Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/output-traces Change
_app-HASH.js gzip 1.22 kB 1.22 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 622 B 622 B ✓
image-HASH.js gzip 4.46 kB 4.46 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 1.91 kB 1.91 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
334f979574ae..6f4.css gzip 106 B 106 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/output-traces Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/output-traces Change
index.html gzip 535 B 535 B ✓
link.html gzip 548 B 548 B ✓
withRouter.html gzip 529 B 529 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: df320e2

@ijjk ijjk merged commit 599081a into vercel:canary Oct 29, 2021
@ijjk ijjk deleted the update/output-traces branch October 29, 2021 22:39
styfle
styfle reviewed Oct 29, 2021
View reviewed changes
Comment thread packages/next/build/webpack/plugins/next-trace-entrypoints-plugin.ts
}

for (const file of fileList!) {
const reason = reasons!.get(file)
Copy link
Copy Markdown
Contributor

@styfle styfle Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should ! be ? Instead

Copy link
Copy Markdown
Member Author

@ijjk ijjk Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh looks like this was left over from a previous change as reasons should never be empty here. I wonder if there's a lint error for un-necessary non-null assertion 🤔

This was referenced Oct 31, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 1, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 8, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jan 21, 2022
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

1 more reviewer

@styfle styfle styfle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot find module 'redux' (Deploy on Vercel w/ yarn workspace)

2 participants

@ijjk @styfle