Update lint-staged example to use node.js path#30510
Merged
kodiakhq[bot] merged 7 commits intovercel:canaryfrom Jan 1, 2022
mi-na-bot:patch-1
Merged
Update lint-staged example to use node.js path#30510kodiakhq[bot] merged 7 commits intovercel:canaryfrom mi-na-bot:patch-1
kodiakhq[bot] merged 7 commits intovercel:canaryfrom
mi-na-bot:patch-1
Conversation
The current example attempts to remove resolve the relative pathname of the absolute pathnames given by `lint-staged` using string manipulation and `process.cwd()`. This is a risky solution because pathnames have many platform dependent edge cases. The example also returns pathnames that are technically wrong in linux. `/home/project/file => /file`, I propose to use the utilities provided by node.js to resolve the relative pathnames, and to format the sample `.lintstagedrc.js` file in a manner easier for novice programmers to understand and modify.
path
styfle
reviewed
Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current example attempts to remove resolve the relative pathname of the absolute pathnames given by
lint-stagedusing string manipulation andprocess.cwd(). This is a risky solution because pathnames have many platform dependent edge cases. The example also returns pathnames that are technically wrong in linux./home/project/file => /file,I propose to use the utilities provided by node.js to resolve the relative pathnames, and to format the sample
.lintstagedrc.jsfile in a manner easier for novice programmers to understand and modify.Bug
fixes #numbercontributing.mdFeature
fixes #numbercontributing.mdDocumentation / Examples
yarn lint