Skip to content

add warning to update featureName in FEATURE_USAGE backend#30283

Merged
ijjk merged 1 commit intovercel:canaryfrom
kyliau:feature-name
Oct 28, 2021
Merged

add warning to update featureName in FEATURE_USAGE backend#30283
ijjk merged 1 commit intovercel:canaryfrom
kyliau:feature-name

Conversation

@kyliau
Copy link
Copy Markdown

@kyliau kyliau commented Oct 25, 2021 •
edited by ijjk
Loading

featureName is restricted to certain values for security reasons.
Before any change is made in the client, backend code has to be updated first.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

add warning to update featureName in FEATURE_USAGE backend
3925c6f 
`featureName` is restricted to certain values for security reasons.
Before any change is made in the client, backend code has to be updated first.
See https://github.com/vercel/next-telemetry/pull/54
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Oct 25, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary kyliau/next.js feature-name Change
buildDuration 19.2s 18.6s -618ms
buildDurationCached 3.9s 3.9s ⚠️ +86ms
nodeModulesSize 475 MB 475 MB -19 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kyliau/next.js feature-name Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.286 3.326 ⚠️ +0.04
/ avg req/sec 760.79 751.68 ⚠️ -9.11
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.54 1.592 ⚠️ +0.05
/error-in-render avg req/sec 1623.23 1570.14 ⚠️ -53.09
Client Bundles (main, webpack, commons)
vercel/next.js canary kyliau/next.js feature-name Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.7 kB 27.7 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 71.5 kB 71.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kyliau/next.js feature-name Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kyliau/next.js feature-name Change
_app-HASH.js gzip 1.23 kB 1.23 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 635 B 635 B ✓
image-HASH.js gzip 4.44 kB 4.44 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.87 kB 1.87 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
334f979574ae..6f4.css gzip 106 B 106 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary kyliau/next.js feature-name Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary kyliau/next.js feature-name Change
index.html gzip 534 B 534 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary kyliau/next.js feature-name Change
buildDuration 16.5s 15.5s -998ms
buildDurationCached 3.9s 4.1s ⚠️ +143ms
nodeModulesSize 475 MB 475 MB -19 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kyliau/next.js feature-name Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.263 3.196 -0.07
/ avg req/sec 766.2 782.27 +16.07
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.539 1.568 ⚠️ +0.03
/error-in-render avg req/sec 1624.78 1594.22 ⚠️ -30.56
Client Bundles (main, webpack, commons)
vercel/next.js canary kyliau/next.js feature-name Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.8 kB 27.8 kB ✓
webpack-HASH.js gzip 1.43 kB 1.43 kB ✓
Overall change 71.6 kB 71.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kyliau/next.js feature-name Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kyliau/next.js feature-name Change
_app-HASH.js gzip 1.22 kB 1.22 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 621 B 621 B ✓
image-HASH.js gzip 4.46 kB 4.46 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 1.9 kB 1.9 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
334f979574ae..6f4.css gzip 106 B 106 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary kyliau/next.js feature-name Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary kyliau/next.js feature-name Change
index.html gzip 534 B 534 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: 3925c6f

@ijjk ijjk merged commit 7077bf8 into vercel:canary Oct 28, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

Assignees

No one assigned

Labels

type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kyliau @ijjk @timneutkens @styfle