Skip to content

Recommend using next CLI for Docker entrypoint and not yarn#29024

Merged
kodiakhq[bot] merged 3 commits intovercel:canaryfrom
stefee:dockerfile
Nov 1, 2021
Merged

Recommend using next CLI for Docker entrypoint and not yarn#29024
kodiakhq[bot] merged 3 commits intovercel:canaryfrom
stefee:dockerfile

Conversation

@stefee
Copy link
Copy Markdown
Contributor

@stefee stefee commented Sep 11, 2021

Fixes #29023

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added type: documentation examples Issue was opened via the examples template. labels Sep 11, 2021
@stefee stefee marked this pull request as ready for review November 1, 2021 19:14
Copy link
Copy Markdown
Contributor

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq Bot merged commit 5abfea3 into vercel:canary Nov 1, 2021
timneutkens pushed a commit to timneutkens/next.js that referenced this pull request Nov 2, 2021
…9024)

Fixes vercel#29023 

## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [x] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [x] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

examples Issue was opened via the examples template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker example wraps the next CLI with yarn in CMD and will not receive process signals (e.g. from Kubernetes)

4 participants