Feat/14701 full reload notification#28866
Merged
kodiakhq[bot] merged 4 commits intovercel:canaryfrom Dec 17, 2021
apollisa:feat/14701-full-reload-notification
Merged
Feat/14701 full reload notification#28866kodiakhq[bot] merged 4 commits intovercel:canaryfrom apollisa:feat/14701-full-reload-notification
kodiakhq[bot] merged 4 commits intovercel:canaryfrom
apollisa:feat/14701-full-reload-notification
Conversation
Author
|
Hello @huozhi, @ijjk, @shuding, @styfle and @timneutkens, may I please request again a review of my PR? |
Closed
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ijjk
reviewed
Dec 13, 2021
ijjk
reviewed
Dec 13, 2021
Member
ijjk
left a comment
There was a problem hiding this comment.
It looks like tests will need updating for this, we could use the NEXT_TEST_MODE env to potentially not require the reload button to be clicked for all tests. Great work on this!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ijjk
approved these changes
Dec 17, 2021
Member
ijjk
left a comment
There was a problem hiding this comment.
We can iterate on the error shown to help track down the source in future PRs but this looks good to start, thanks for the PR!
Member
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | apollisa/next.js feat/14701-full-reload-notification | Change | |
|---|---|---|---|
| buildDuration | 17.3s | 17.2s | -62ms |
| buildDurationCached | 3.2s | 3.3s | |
| nodeModulesSize | 348 MB | 348 MB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | apollisa/next.js feat/14701-full-reload-notification | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.834 | 2.762 | -0.07 |
| / avg req/sec | 882.21 | 905.04 | +22.83 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.267 | 1.2 | -0.07 |
| /error-in-render avg req/sec | 1973.5 | 2083.95 | +110.45 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | apollisa/next.js feat/14701-full-reload-notification | Change | |
|---|---|---|---|
| 450.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
| main-HASH.js gzip | 30.2 kB | 30.2 kB | ✓ |
| webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
| Overall change | 74 kB | 74 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | apollisa/next.js feat/14701-full-reload-notification | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | apollisa/next.js feat/14701-full-reload-notification | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.37 kB | 1.37 kB | ✓ |
| _error-HASH.js gzip | 194 B | 194 B | ✓ |
| amp-HASH.js gzip | 312 B | 312 B | ✓ |
| css-HASH.js gzip | 326 B | 326 B | ✓ |
| dynamic-HASH.js gzip | 2.37 kB | 2.37 kB | ✓ |
| head-HASH.js gzip | 350 B | 350 B | ✓ |
| hooks-HASH.js gzip | 919 B | 919 B | ✓ |
| image-HASH.js gzip | 4.73 kB | 4.73 kB | ✓ |
| index-HASH.js gzip | 263 B | 263 B | ✓ |
| link-HASH.js gzip | 2.13 kB | 2.13 kB | ✓ |
| routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
| script-HASH.js gzip | 383 B | 383 B | ✓ |
| withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
| 85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
| Overall change | 14.1 kB | 14.1 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | apollisa/next.js feat/14701-full-reload-notification | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 459 B | 459 B | ✓ |
| Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | apollisa/next.js feat/14701-full-reload-notification | Change | |
|---|---|---|---|
| index.html gzip | 532 B | 532 B | ✓ |
| link.html gzip | 546 B | 546 B | ✓ |
| withRouter.html gzip | 526 B | 526 B | ✓ |
| Overall change | 1.6 kB | 1.6 kB | ✓ |
Default Build with SWC (Increase detected ⚠️ )
General Overall increase ⚠️
| vercel/next.js canary | apollisa/next.js feat/14701-full-reload-notification | Change | |
|---|---|---|---|
| buildDuration | 19s | 18.8s | -175ms |
| buildDurationCached | 3.3s | 3.3s | |
| nodeModulesSize | 348 MB | 348 MB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | apollisa/next.js feat/14701-full-reload-notification | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.857 | 2.868 | |
| / avg req/sec | 875.16 | 871.61 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.289 | 1.27 | -0.02 |
| /error-in-render avg req/sec | 1938.93 | 1968.36 | +29.43 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | apollisa/next.js feat/14701-full-reload-notification | Change | |
|---|---|---|---|
| 450.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
| main-HASH.js gzip | 30.3 kB | 30.3 kB | ✓ |
| webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
| Overall change | 74.3 kB | 74.3 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | apollisa/next.js feat/14701-full-reload-notification | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | apollisa/next.js feat/14701-full-reload-notification | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.35 kB | 1.35 kB | ✓ |
| _error-HASH.js gzip | 180 B | 180 B | ✓ |
| amp-HASH.js gzip | 305 B | 305 B | ✓ |
| css-HASH.js gzip | 321 B | 321 B | ✓ |
| dynamic-HASH.js gzip | 2.36 kB | 2.36 kB | ✓ |
| head-HASH.js gzip | 342 B | 342 B | ✓ |
| hooks-HASH.js gzip | 906 B | 906 B | ✓ |
| image-HASH.js gzip | 4.75 kB | 4.75 kB | ✓ |
| index-HASH.js gzip | 256 B | 256 B | ✓ |
| link-HASH.js gzip | 2.19 kB | 2.19 kB | ✓ |
| routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
| script-HASH.js gzip | 375 B | 375 B | ✓ |
| withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
| 85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
| Overall change | 14.1 kB | 14.1 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | apollisa/next.js feat/14701-full-reload-notification | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 459 B | 459 B | ✓ |
| Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | apollisa/next.js feat/14701-full-reload-notification | Change | |
|---|---|---|---|
| index.html gzip | 532 B | 532 B | ✓ |
| link.html gzip | 546 B | 546 B | ✓ |
| withRouter.html gzip | 526 B | 526 B | ✓ |
| Overall change | 1.6 kB | 1.6 kB | ✓ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
contributing.mdCloses: #14701