fix(ast-spec): a JSXEmptyExpression is not a possible JSXExpression#6321
Merged
bradzacher merged 1 commit intotypescript-eslint:mainfrom Jan 30, 2023
MageJohn:fix-6315
Merged
fix(ast-spec): a JSXEmptyExpression is not a possible JSXExpression#6321bradzacher merged 1 commit intotypescript-eslint:mainfrom MageJohn:fix-6315
bradzacher merged 1 commit intotypescript-eslint:mainfrom
MageJohn:fix-6315
Conversation
Contributor
|
Thanks for the PR, @MageJohn! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
As described in the linked issue, a
JSXEmptyExpressionnode is only generated as the child of aJSXExpressionContainernode, and so cannot appear in the same place as aJSXExpression.